Bug 177637 - Not Implemented: Open Folder in Tabs' with SSH bookmarks
Summary: Not Implemented: Open Folder in Tabs' with SSH bookmarks
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-13 00:05 UTC by Will Angenent
Modified: 2009-10-10 19:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
konsole openUrls SSH patch (3.67 KB, patch)
2008-12-13 00:06 UTC, Will Angenent 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Will Angenent 2008-12-13 00:05:12 UTC 
Version:           4.1.82, svn r894579 (using Devel)
Compiler:          gcc version 4.3.2 (Ubuntu 4.3.2-1ubuntu11) 
OS:                Linux
Installed from:    Compiled sources

Hi,

I've implemented "TODO about implementing support for 'Open Folder in Tabs' with SSH bookmarks" from r756953 in MainWindow.cpp.

I've made a simple patch to allow SSH sessions to be handled when opening all
URLS in a bookmarked tab. I had to introduce a new signal + slot and copy
some code from SessionController::openUrl into Application.cpp to do
finish it off. I know, code duplication is evil, but I'm afraid I don't know enough about the konsole innards to know the best place to put the common code.

The patch is (or will be) attached.

Regards,
Will Angenent
Comment 1 Will Angenent 2008-12-13 00:06:17 UTC 
Created attachment 29282 [details]
konsole openUrls SSH patch
Comment 2 Kurt Hindenburg 2009-03-15 23:08:44 UTC 
I implemented ssh in bookmarks a few weeks ago.

This patch is to allow you to 'Open link' on 'ssh://machine' which opens a new window.

The patch appears to work as expected
Comment 3 Kurt Hindenburg 2009-03-15 23:15:07 UTC 
I'm not really sure I see a reason for this.  I can understand wanting to open a file or web site.  But how often is there some 'ssh://machine' on the Konsole display that you want to 'Open link'?
Comment 4 Will Angenent 2009-03-16 00:02:47 UTC 
One thing I have to do regularly though is ssh to she same 6 or so machines. Open Folder in Tabs should have been doing exactly what I wanted. When I found the TODO in the code I took it upon myself to fix it.
Comment 5 Kurt Hindenburg 2009-03-16 00:26:57 UTC 
OK, I understand now.  This is after you've 'Bookmark tabs as folders'.
Comment 6 Will Angenent 2009-03-16 00:31:04 UTC 
You got it. I'm afraid my patch doesn't deal with the port number though, but that should be easily fixed, judging by your r930321 commit.
Comment 7 Martti Laaksonen 2009-10-10 11:24:48 UTC 
Are there any plans to get this fixed? 

By now I would consider this a bug since it is possible to create bookmarks with SSH URLs and even create a bookmark folder from all open SSH connection tabs in konsole but not be able to open such a bookmark folder in tabs.

Tested with Konsole 2.3.1 (KDE 4.3.1).
Comment 8 Kurt Hindenburg 2009-10-10 19:35:21 UTC 
SVN commit 1033653 by hindenburg:

Allow 'Open Folder in Tabs' to support SSH bookmarks.

Thanks to Will Angenent for patch.

BUG: 177637


 M  +27 -0     Application.cpp  
 M  +1 -0      Application.h  
 M  +3 -1      MainWindow.cpp  
 M  +11 -0     MainWindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1033653