Version: (using Devel) Installed from: Compiled sources Currently when dragging a card, KPat checks all piles currently under the card and highlights all those that are valid drop points for the card being moved. In certain situations in certain games, this can lead to up to four piles being highlighted at once. The problem is that from any given position, the card can only actually be dropped on a single pile. Highlighting more than one pile, when in reality only one is the "real" drop target is a little misleading and (in my opinion) looks bad. The attached patch essentially extracts the pile selection code from the drop function into its own method. This method is then called by both the hover logic (for selecting which pile to highlight) and the drop function (for selecting the pile to drop on). The result is less code and more consistency.
Created attachment 29003 [details] Patch to reuse the same code for drops and highlights in DealerScene.
*** Bug 177283 has been marked as a duplicate of this bug. ***
applied
your patch has an ugly side effect: cards don't move back to their origin pile.
SVN commit 902245 by coolo: Parker forgot one else CCBUG: 176740 M +1 -0 dealer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=902245
SVN commit 906434 by coates: Stephan forgot to actually add the else in his "Parker forgot one else" commit. ;) Not callling moveCardsBack caused misdropped cards to stay floating out in the middle of nowhere. Calling moveCardsBack everytime caused the card drop animation to be skipped as noticed by Matthew Woehlke. I believe this change represents the desired behaviour. CCBUG: 176740 M +4 -1 dealer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=906434
Yes, smooth drop is working again. Thanks for the quick fix!