Bug 176663 - installing a new script requires a restart of amarok
Summary: installing a new script requires a restart of amarok
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Tools/Script Manager (show other bugs)
Version: 2.6-git
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 02:18 UTC by Casey Link
Modified: 2014-02-26 17:32 UTC (History)
4 users (show)

See Also:
Latest Commit: http://commits.kde.org/amarok/a83011baea92d85db102a8418013c3968e31ec80
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Casey Link 2008-12-02 02:18:04 UTC 
Version:           SVN (using KDE 4.1.3)
OS:                Linux
Installed from:    Ubuntu Packages

It would be nice if I could install a new script and immediately start using it. I realize some scripts might require a restart, but all of them?
Comment 1 Seb Ruiz 2008-12-02 04:04:37 UTC 
Yep, this is bad. I'm upgrading it from a wish to a bug since users shouldn't have to put up with application restarts in this day and age.
Comment 2 Mark Kretschmann 2008-12-02 11:22:02 UTC 
Agreed. I have talked to Peter about this and I understand that the problem is with the KPluginSelector widget, which is very limited (typical KDE style).

Peter said he'll try to hack around its limitations, but this won't be easy.
Comment 3 Peter ZHOU 2008-12-02 13:21:39 UTC 
Yes. And a configuration button for each script is needed, which also need some hack on the KPluginSelector. I will write a patch for this, but I guess we need to wait till KDE 4.3 at least.
Comment 4 Seb Ruiz 2008-12-02 13:34:31 UTC 
Peter: no can do. I don't believe we can have a min dependency of KDE 4.3. You'll have to work around it in Amarok.
Comment 5 Mark Kretschmann 2008-12-02 15:42:34 UTC 
What you could do for now is just copy the KPluginSelector code into our source tree and patch it.
Comment 6 Myriam Schweingruber 2009-08-02 13:15:55 UTC 
Any news on this one? Last comment is more than 7 months old now and It's still there in current 2.2-git
Comment 7 Myriam Schweingruber 2009-11-04 00:22:26 UTC 
Changing version...
Comment 8 Myriam Schweingruber 2011-06-04 11:47:46 UTC 
This is an automated message from the triager:

Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug?

Without feedback within a month we will close this bug as resolved.

Thank you for your understanding.
Comment 9 Alexander Potashev 2011-06-04 15:08:09 UTC 
The problem is still present in 2.4.1.
Comment 10 Myriam Schweingruber 2011-06-04 16:34:31 UTC 
Thank you for the feedback, confirmed on Amarok 2.4-git
Comment 11 Myriam Schweingruber 2012-01-03 11:33:36 UTC 
Confirmed with Amarok 2.5, bumping version.
Comment 12 Mayank Madan 2012-11-29 18:26:19 UTC 
Problem persists in Amarok 2.6-git
Comment 13 Anmol Ahuja 2014-02-26 17:32:46 UTC 
Git commit a83011baea92d85db102a8418013c3968e31ec80 by Anmol Ahuja.
Committed on 23/02/2014 at 07:21.
Pushed by anmolahuja into branch 'master'.

Add script install and remove buttons.
Support installation of zipped scripts.

M  +0    -3    src/ScriptUpdater.h
M  +4    -7    src/configdialog/dialogs/ScriptSelector.cpp
M  +1    -2    src/configdialog/dialogs/ScriptSelector.h
M  +106  -5    src/configdialog/dialogs/ScriptsConfig.cpp
M  +7    -2    src/configdialog/dialogs/ScriptsConfig.h
M  +0    -1    src/scriptmanager/ScriptItem.cpp
M  +1    -4    src/scriptmanager/ScriptManager.cpp
M  +0    -5    src/scriptmanager/ScriptManager.h

http://commits.kde.org/amarok/a83011baea92d85db102a8418013c3968e31ec80