Bug 176402 - Embedded id3v2 cover art not displayed
Summary: Embedded id3v2 cover art not displayed
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.3-GIT
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 96667 183751 195728 207402 241045 244266 244434 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-29 04:14 UTC by Syam
Modified: 2010-10-10 16:15 UTC (History)
22 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Same image repeated for several different albums (46.71 KB, image/png)
2010-10-10 12:14 UTC, Syam
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Syam 2008-11-29 04:14:02 UTC
Version:           1.94 (using KDE 4.1.3)
OS:                Linux
Installed from:    Fedora RPMs

I've lots of mp3 files with id3v2.4 embedded covert art (inserted using kid3/taglib). They used to work just fine with Amarok 1.4.
But with Amarok 1.94 (2.0 beta?) on Fedora 10, the covert art are not displayed. I'm still able to see the images using kid3/taglib.
Comment 1 Mark Kretschmann 2008-11-29 11:37:16 UTC
Could you please make one of these files accessible to us, so that we can reproduce the problem?
Comment 2 Seb Ruiz 2008-11-29 13:22:18 UTC
@Mark: reading embedded artwork from files is not implemented in A2, so it's not a bug, as much as a missing feature.
Comment 3 Mark Kretschmann 2008-11-29 13:24:19 UTC
Oh ok, thanks for clearing that up.
Comment 4 Syam 2008-11-29 14:57:01 UTC
@Seb: That's one missing killer feature :-(
But I'm confused since your own blog (dated June 2008) says Amarok 2 supports cover art (http://www.sebruiz.net/337).
Comment 5 Syam 2008-11-29 14:58:07 UTC
Oops.. sorry.. I didn't read the blog carefully enough. It does say that embedded artwork is not supported. My bad!
Comment 6 Dan Meltzer 2009-02-09 06:28:05 UTC
*** Bug 183751 has been marked as a duplicate of this bug. ***
Comment 7 Syam 2009-05-01 18:34:33 UTC
Will this make it to any Amarok release? I'd like to have my MP3 metadata embedded in the files themselves (and not separate image files). That way, I get better interoperability between applications (and even cell phone media players can display the embedded artwork).
Please see the re-worked digiKam first-run screen for a similar use-case: http://www.flickr.com/photos/digikam/3489923047/
Comment 8 Seb Ruiz 2009-05-03 06:11:32 UTC
@Syam: yes, we will bring it back but it is not on the roadmap yet. You'll be the first to know.
Comment 9 Syam 2009-05-03 09:51:42 UTC
@Seb: Thanks
Comment 10 Seb Ruiz 2009-06-09 04:35:46 UTC
*** Bug 195728 has been marked as a duplicate of this bug. ***
Comment 11 Myriam Schweingruber 2009-08-02 13:14:44 UTC
Any news on this?
Comment 12 Karthik Periagaram 2009-08-02 19:49:00 UTC
As a user, I've taken to using the album.jpg approach (Most music players will use a jpeg image named album.jpg in the directory containing the contents of the album. This works fine in Amarok 2. A quick way to do this is to fire up kid3, select a song, choose the Picture field, Edit and Export the image as album.jpg in the directory containing the song) but it will be a tedious solution to the problem if the library contains thousands of songs.

Perhaps someone can provide a script that will recursively comb a music directory, read the embedded image in the tags and export them as album.jpg in the respective directory? That will be a useful stopgap till this feature is implemented in Amarok.
Comment 13 Syam 2009-08-03 03:57:11 UTC
(In reply to comment #12)
That'd work only if you have strictly 'one album, one directory' structure. My collection has lots of single tracks and I don't group them in separate directories - they can be grouped by album in Amarok anyway. So I can't use this method. :-(
Comment 14 Bob Campbell 2009-08-03 07:32:21 UTC
I also submitted this bug (and had it rolled in to here) and, like Syam, I have my music organized in such a way that using the album.jpg trick wouldn't work. Each artist has a directory, but no subdirectories per album.
Comment 15 Myriam Schweingruber 2009-08-03 11:17:59 UTC
*** Bug 96667 has been marked as a duplicate of this bug. ***
Comment 16 Myriam Schweingruber 2009-08-25 17:55:52 UTC
Setting as a wish, as this is a missing feature, not a bug.
Comment 17 Myriam Schweingruber 2009-09-15 01:02:10 UTC
*** Bug 207402 has been marked as a duplicate of this bug. ***
Comment 18 Myriam Schweingruber 2009-10-01 10:48:58 UTC
*** Bug 207402 has been marked as a duplicate of this bug. ***
Comment 19 Justin Newman 2009-10-01 17:44:44 UTC
Since Myriam fails reading comprehension and somehow thinks this bug solves 207402, let me just paste the other here and be done:

Amarok should support (1) attempting to read [album art and lyrics] tags before fetching lyrics/album art from the net and (2) writing these tags instead of storing it in the local database.

For (1), reading from these tags would make switching TO Amarok easier for a
large number of people.

For (2), writing these tags would (a) make losing your database less painful
and (b) make using various applications to access the same library more hassle
free.
Comment 20 Mark Kretschmann 2009-10-01 19:51:11 UTC
Please watch your language, Justin. We have to process a huge amount of reports every day, and sometimes mistakes happen. Just humans, you see :)
Comment 21 Justin Newman 2009-10-01 20:17:11 UTC
That's true, and I apologize for the rude comment. However it was closed as a duplicate once. I made my case and re-opened it, several people agreed, and it was closed as a duplicate again, with commentary. Hardly a 'mistake.'

At any rate, you guys can do what you want with it.
Comment 22 Eike 2009-12-30 18:04:57 UTC
Showing embedded cover artwork would be a very great feature of amarok! All my (mp3) files are added with covers and I'd very like to see these covers in Amarok (again).
Comment 23 Karthik Periagaram 2009-12-30 20:54:20 UTC
This problem seems to have already been solved by the bangarang devs.

For those not in the know, bangarang is a sort of media player/manager for KDE4 nearing its first release. Here's their page on kde-apps.org: http://www.kde-apps.org/content/show.php/Bangarang?content=113305

Pertinent to this wishlist, the current version of bangarang reads album artwork from mp3 files. I am not really adept at coding, but it might be easy to implement this in amarok by reusing the code from bangarang.
Comment 24 Andreas Kirsch 2010-01-26 09:28:54 UTC
is it so hard to add this feature to amarok, again?!
Comment 25 Myriam Schweingruber 2010-01-26 13:10:15 UTC
(In reply to comment #24)
> is it so hard to add this feature to amarok, again?!

Well, the developers have only two hands each and the day only as 24 hours (not to mention they work for free). You are welcome to give a hand :)
Comment 26 Mark Kretschmann 2010-02-26 06:35:32 UTC
Good news, everyone :) Amarok 2.3 will finally have this feature:


commit a0c4a6c706d6f4f6cf22740bfa4aec768a7c4b87
Author: ecroy <ecroy@gmx.net>
Date:   Fri Feb 26 01:41:55 2010 +0100

    Add embedded cover art support
Comment 27 Syam 2010-02-26 08:29:36 UTC
Wow! This has to be the best Amarok/KDE news I've heard in a while. Thanks devs, and thanks to Mark for the heads up.
Comment 28 Karthik Periagaram 2010-02-26 08:48:17 UTC
YES!!! Thanks so much for this! :)
Comment 29 Andreas Kirsch 2010-02-26 08:57:56 UTC
Thank you for this good information.go amarok go :)
Comment 30 Jeff Mitchell 2010-02-26 20:20:58 UTC
This feature as implemented has serious issues and should never have been merged into 2.3, which is deep in feature freeze. It is going to be reverted.

Look for it in 2.3.1.
Comment 31 Harald Nikolisin 2010-06-02 23:06:16 UTC
I'm disappointed - it's not in 2.3.1 :(
Can anyone specify a Target Version for this feature?
Comment 32 ecroy 2010-06-03 00:03:02 UTC
There was some controversy about the way my patch implemented this feature - unfortunately I did not find enough time to do it differently because the suggested ways seemed far more intrusive to me. Hopefully somebody more familiar with the codebase picks up on this, but currently nobody seems to be working on it :(
Comment 33 Myriam Schweingruber 2010-06-08 00:22:38 UTC
*** Bug 241045 has been marked as a duplicate of this bug. ***
Comment 34 Myriam Schweingruber 2010-07-12 02:08:25 UTC
*** Bug 244266 has been marked as a duplicate of this bug. ***
Comment 35 Myriam Schweingruber 2010-07-12 22:35:30 UTC
*** Bug 244434 has been marked as a duplicate of this bug. ***
Comment 36 Jeff Mitchell 2010-08-03 14:18:55 UTC
FYI,

I've implemented this feature for the upcoming 2.3.2. It currently works only for MP3s, as I don't have any other types of files with embedded cover art with which to test.

I haven't closed this because there is still some work to do. The changes invalidate the cached covers, including downloaded covers. One of the other developers is implementing a fallback system to get files to the correct new places if they don't exist there already.
Comment 37 joe 2010-08-05 20:44:42 UTC
@Jeff Mitchell,
thank you, it works :)
Comment 38 Jeff Mitchell 2010-08-06 21:43:00 UTC
Sure. To give a shout-out where it's due, Ralf Engels is doing some nice work now cleaning the whole system up. (That's also why I'm keeping this as opened, to help remind me to keep tabs on that.)
Comment 39 Syam 2010-08-09 05:30:52 UTC
Thank you Jeff Mitchell, Ralf Engels and all the other devs/testers working on this. Thanks a lot..
Comment 40 Syam 2010-10-10 12:13:38 UTC
I just installed Amarok 2.3.2 (from kde-testing repo of Fedora KDE SIG), and album art images are mostly displayed wrong.
A couple of images are wrongly used for a large number of albums (see the attached screenshot).
Comment 41 Syam 2010-10-10 12:14:42 UTC
Created attachment 52385 [details]
Same image repeated for several different albums
Comment 42 Jeff Mitchell 2010-10-10 16:15:53 UTC
Please open a new bug for this.