Bug 175841 - No newlines displayed for incoming icq messages
Summary: No newlines displayed for incoming icq messages
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: OTR Plugin (show other bugs)
Version: 0.60.2
Platform: Ubuntu Unspecified
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-22 22:33 UTC by Johannes Wienke
Modified: 2009-03-06 21:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Chat window contents that should contain newlines. ICQ numbers blanked out. (2.92 KB, text/html)
2008-12-28 00:37 UTC, Johannes Wienke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Wienke 2008-11-22 22:33:20 UTC
Version:           0.60.2 (using KDE 4.1.2)
Installed from:    Ubuntu Packages

Newlines in incoming icq messages are not displayed. Other protocols work. I also tried all possible settings for overriding sender formats in the preferences without success.
Comment 1 Roman Jarosz 2008-12-25 18:35:27 UTC
Could you tell me what IM program does the user use?

It doesn't look like Kopete bug because it works here with Kopete or ICQ 6.
Comment 2 Johannes Wienke 2008-12-25 23:11:54 UTC
To me this absolutely looks like a Kopete problem because I never received a message with visible newlines from an ICQ user since KDE 4. But I just checked it with the new ICQ 6.5. All configuration files and directories for Kopete are new since I switched to KDE 4 and not converted from KDE 3.5.
Comment 3 Roman Jarosz 2008-12-25 23:23:32 UTC
So it doesn't work for you with ICQ 6.5 or didn't checked it yet?
Comment 4 Johannes Wienke 2008-12-25 23:26:23 UTC
Doesn't work with any client and with ICQ 6.5 I just checked that it really doesn't work.
Comment 5 Roman Jarosz 2008-12-25 23:36:15 UTC
That's odd it works here with Kopete from trunk and from KDE 4.1.4.
I have couple of questions:
Which chat style do you use?
Which chat font do you use?
Which encoding do you have in ICQ account properties?
Do you see any relevant messages in console if you run Kopete from it?
Comment 6 Johannes Wienke 2008-12-26 00:00:00 UTC
Ok,

I use the "Clear" style but I just checked it with "Clean" and there it also doesn't work.

Font is Bitstream Vera Sans but I don't think this is related. I also used this before switching to KDE 4 and even now newlines work with all other protocols I use.

Encoding is ISO-8859-1.

Kopete doesn't seem to be compiled with the debug option under Kubuntu, the only output since starting Kopete I get is:

kopete(1289) Kopete::IdentityManager::load: Created identity  "WJ2bgTX84n"
kopete(1289) Kopete::AccountManager::setOnlineStatus: category:  2
QFSFileEngine::open: No file name specified
QObject: Do not delete object, 'unnamed', during its event handler!
KCrash: Application 'kopete' crashing...
sock_file=/home/languitar/.kde/socket-little-tux/kdeinit4__0
Unable to start Dr. Konqi

These are all boot up and switching to online messages.
Comment 7 Roman Jarosz 2008-12-26 10:21:11 UTC
Hi, could you catch ICQ packets when you receive message with new lines from ICQ 6.5 with wireshark and send it to kedgedev@centrum.cz?
 
Wireshark steps.
2. Start wireshark.
3. From menu choose Capture->Options...
4. Choose interface probably eth0
5. Add "port 5190" (without quotes) into the combobox next to Capture Filter
button.
6. Press start.
7. Send message
8. Press stop.
9. File->Save and save it.
 
If you need additional help you can find me (kedge) in Kopete irc channel
 
Comment 8 Johannes Wienke 2008-12-26 12:26:45 UTC
Ok, mail is sent.
Comment 9 Johannes Wienke 2008-12-26 12:30:29 UTC
Just to add the relevant parts here:

00e0  01 00 01 30 00 31 2e 20  7a 65 69 6c 65 0d 0a 32   ...0.1.  zeile..2
00f0  2e 20 7a 65 69 6c 65 0d  0a 0d 0a 33 2e 20 7a 65   . zeile. ...3. ze
0100  69 6c 65 2c 20 64 61 76  6f 72 20 6c 65 65 72 7a   ile, dav or leerz
0110  65 69 6c 65 00 00 00 00  00 ff ff ff 00 00 0b 00   eile.... ........

each "n. zeile" should be on its own line and the lines in the message are correctly separated by 0d 0a which is CR LF.
Comment 10 Roman Jarosz 2008-12-27 16:15:36 UTC
Still cannot reproduce this here :(
Could you send message with new lines to someone and send it back to Kopete from other program and save chat to file in Kopete chat windows and send it to me, thanks.

Btw. which Qt version do you use?
Comment 11 Johannes Wienke 2008-12-28 00:35:43 UTC
Qt is the default for Intrepid Ibex: 4.4.3
Comment 12 Johannes Wienke 2008-12-28 00:37:39 UTC
Created attachment 29685 [details]
Chat window contents that should contain newlines. ICQ numbers blanked out.

The message that was sent was
"ha
ll
o"
Comment 13 Roman Jarosz 2008-12-28 10:57:53 UTC
Is there any chance you are using Kopete AIM account with ICQ number?

That's the only thing that could cause it apart from not working regular expressions in Qt (but that's unlikely)
Comment 14 Johannes Wienke 2008-12-28 11:46:34 UTC
No, it's a usual ICQ account.
Comment 15 Johannes Wienke 2008-12-28 12:24:57 UTC
I found the problem. It's the OTR plugin that swallows the new lines, even though the conversations aren't encoded.
Comment 16 Roman Jarosz 2008-12-28 13:00:29 UTC
Cool, I'll look if I can fix it in OTR.
Comment 17 Roman Jarosz 2008-12-28 13:49:34 UTC
I see here in chat window "The following message received from xxxxxxx was not encrypted: [d j huiuhi]".
The text is from ort library (not from Kopete ort plugin) and the new lines (<br />) are replaced with spaces but it only shows when I force ort to decrypt every message even the one that are not encrypted.

So IMHO it should be closed or reported to the libort
Comment 18 Johannes Wienke 2008-12-28 13:57:47 UTC
I'm not into that code but wouldn't the simple solution be to force decryption only for encrypted messages?

Nevertheless my problem existed even for conversation where otr wasn't enabled at all.
Comment 19 Roman Jarosz 2008-12-28 14:22:24 UTC
> Nevertheless my problem existed even for conversation where otr wasn't enabled at all.

It works here (Kopete from KDE 4.2) if in ORT I have: Default ORT policy set to opportunistic.
Comment 20 Johannes Wienke 2008-12-28 14:35:54 UTC
That's exactly the same setting I use. Which versions of Kopete OTR and libotr do you use?
Comment 21 Roman Jarosz 2008-12-28 14:58:04 UTC
Recent Kopete from trunk (so something after KDE 4.2 beta2) and net-libs/libotr-3.2.0
Comment 22 Johannes Wienke 2008-12-28 15:49:03 UTC
Ok, I'm using the KDE 4.1 version. Was there any relevant change in the otr plugin or Kopete itself since then that could affect this problem?
Comment 23 Johannes Wienke 2009-03-06 21:36:46 UTC
Seems to be working now with kopete 4.2