Version: (using Devel) OS: MS Windows Installed from: Compiled sources especially nasty: - read tags from a file (including some trailing bytes of garbage) - append some tag data - write file: the garbage stays between old and new tag data -> during the next read of the file, taglib will misinterpret everything behind the former garbage
Created attachment 28733 [details] do extra range checking this one goes into directory taglib/riff patch idea: data portions smaller than 8 bytes cannot be chunks
please use the cumulative patch added to Bug 171957 (taglib corrupts ogg files) instead
SVN commit 1003745 by lalinsky: Handle RIFF chunk padding and ignore trailing garbage This is based on patches by Marc Halbruegge, but those only deal with read-only cases. The code now also correctly adds padding to RIFF chunks, and calculates offsets in chunkData taking the padding into account. BUG:171957 BUG:175781 M +34 -4 taglib/riff/rifffile.cpp M +4 -0 tests/CMakeLists.txt AM tests/data/empty.aiff AM tests/test_aiff.cpp [License: UNKNOWN] AM tests/test_riff.cpp [License: UNKNOWN] WebSVN link: http://websvn.kde.org/?view=rev&revision=1003745