Bug 174194 - Force documentation and force sections Settings are replaced
Summary: Force documentation and force sections Settings are replaced
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Lays Rodrigues
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-03 19:19 UTC by Ferenc Veres
Modified: 2016-05-10 15:42 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/umbrello/e4954692f7ef39c0feaec6354d456f48d9cc5440
Version Fixed In: 2.19.2 (KDE Applications 16.04.2)

Attachments
Fix bug 174194 (1.33 KB, patch)
2016-05-10 14:57 UTC, Lays Rodrigues 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ferenc Veres 2008-11-03 19:19:36 UTC 
Version:           2.1.2 (using Devel)
Compiler:          gcc 
OS:                Linux
Installed from:    Compiled sources

In code generation the two checkboxes on the formatting tab are reloaded replaced from the settings. The fix is as simple like:

[lion2@localhost umbrello]$ svn diff umbrello/codegenerators/codegenerationpolicy.cpp
Index: umbrello/codegenerators/codegenerationpolicy.cpp
===================================================================
--- umbrello/codegenerators/codegenerationpolicy.cpp    (revision 879597)
+++ umbrello/codegenerators/codegenerationpolicy.cpp    (working copy)


-    setCodeVerboseSectionComments(UmbrelloSettings::forceDoc());
-    setCodeVerboseDocumentComments(UmbrelloSettings::forceSections());
+    setCodeVerboseSectionComments(UmbrelloSettings::forceSections());
+    setCodeVerboseDocumentComments(UmbrelloSettings::forceDoc());
Comment 1 Ralf Habacker 2016-05-05 02:45:09 UTC 
@Lays: Please try to confirm this bug.
Comment 2 Lays Rodrigues 2016-05-10 14:57:20 UTC 
Created attachment 98879 [details]
Fix bug 174194

Ralf, also you need to add the patch about Fix-of-call-of-overloaded-abs-qreal-is-ambiguous.patch in Master and framerworks, because they aren't compiling without fix this bug.
Comment 3 Lays Rodrigues 2016-05-10 14:57:55 UTC 
bug confirmed, also submitted a patch to solve it.
Comment 4 Ralf Habacker 2016-05-10 15:23:09 UTC 
(In reply to Lays Rodrigues from comment #2)
> Ralf, also you need to add the patch about
> Fix-of-call-of-overloaded-abs-qreal-is-ambiguous.patch in Master and
> framerworks, because they aren't compiling without fix this bug.
done
Comment 5 Ralf Habacker 2016-05-10 15:35:35 UTC 
(In reply to Lays Rodrigues from comment #3)
> bug confirmed, also submitted a patch to solve it.
You verified that the patch solves the issue ?

Bugs are normally fixed in the stable branch. Exceptions are bugfixes for features not in the stable branch.
Commits for bug fixes can have additional keywords to automatically close the bug and to set the version the bug has been fixed in e.g. for this bug this is:

BUG: 174194
FIXED-IN:2.19.2 (KDE Applications 16.04.2)

> Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>
Please use this only if you wrote the patch and claim authorship see http://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for
Comment 6 Ralf Habacker 2016-05-10 15:37:36 UTC 
> Fix Bug 174194
> Fix inversion of force documentation and sections.

The commit message should contain a short message about what has been fixed e.g  
The bug number belongs at the bottom of the commit message see comment 5
Comment 7 Ralf Habacker 2016-05-10 15:42:54 UTC 
Git commit e4954692f7ef39c0feaec6354d456f48d9cc5440 by Ralf Habacker, on behalf of Lays Rodrigues.
Committed on 10/05/2016 at 15:42.
Pushed by habacker into branch 'Applications/16.04'.

Fix 'inversion of force documentation and sections' in code generator settings.
FIXED-IN:2.19.2 (KDE Applications 16.04.2)

M  +2    -2    umbrello/codegenerators/codegenerationpolicy.cpp

http://commits.kde.org/umbrello/e4954692f7ef39c0feaec6354d456f48d9cc5440