Bug 173546 - KMessageBox' palette screws up scrollbars for some styles
Summary: KMessageBox' palette screws up scrollbars for some styles
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: 4.1
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
Depends on:
Reported: 2008-10-26 00:25 UTC by Huynh Huu Long
Modified: 2008-10-26 16:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

patch from KDE/kdelibs/kdeui (881 bytes, patch)
2008-10-26 00:27 UTC, Huynh Huu Long
updated patch (542 bytes, patch)
2008-10-26 16:05 UTC, Huynh Huu Long

Note You need to log in before you can comment on or make changes to this bug.
Description Huynh Huu Long 2008-10-26 00:25:42 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

KMessageBox forces the ScrollArea to have a transparent background (for example to fit with custom backgrounds like the oxyegn gradient). Unfortunately also the scrollbars are affected and especially Plastique's but also Oxygen's scrollbars don't look as expected. Instead only the viewports palette should be modified, if at all.

kdialog --msgbox "`cat Makefile`" --style=plastique
kdialog --msgbox "`cat WhateverFile`" --style=oxygen
Comment 1 Huynh Huu Long 2008-10-26 00:27:29 UTC
Created attachment 28145 [details]
patch from KDE/kdelibs/kdeui

Here's a proposal patch
Comment 2 Urs Wolfer 2008-10-26 10:29:16 UTC
Patch looks good to me. Though I'm not sure if this line is required at all:
+        if (messageScrollArea->viewport())
+        {

(if it is, please write as:
+        if (messageScrollArea->viewport()) {
Comment 3 Huynh Huu Long 2008-10-26 16:05:56 UTC
Created attachment 28161 [details]
updated patch

You're right, that check doesn't make much sense :) I was just a bit paranoid :P
Comment 4 Huynh Huu Long 2008-10-26 16:32:42 UTC
SVN commit 876135 by huynhhuu:

Fix graphical errors with some styles. We only need to set the viewport transparent, not the scrollbars.
BUG: 173546

 M  +1 -1      kmessagebox.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=876135