Version: 0.7.2 (using KDE 4.1.2) OS: Linux Installed from: Fedora RPMs Please add the option to set up a hotkey to turn the "Change colors" switch on and off (currently reachable via Settings -> Configure Okular -> Accessibility -> Change colors").
Lack of fast way to switch off/on change color option makes this option useless. There are some pdfs that look terrible with change color switched on - the ones with photos are good example.
Created attachment 83100 [details] pacth fix
Sorry for double post, first patch and I have just figured that the patch comment goes to the devel list... Added default shortcut Ctrl + I for change colors. This should have the exact same of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then Ok, therefore changing the saved configs. I am not sure if: - viewport()->update() is the right way to update the screen after this config change? Where is the `update()` method defined? If I tracked well, viewport() returns a DocumentViewport, which does not seem to have such a method. - did I put things in the right place but it seems to work.
please post the patch to reviewboard.kde.org
*** Bug 266157 has been marked as a duplicate of this bug. ***
Git commit afc74e76ef70abf70d993d4099000742080a8a85 by Albert Astals Cid, on behalf of Ciro Santilli. Committed on 26/10/2013 at 09:40. Pushed by aacid into branch 'master'. Add an action to toggle Change Colors This has the exact same behaviour of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then clicking Ok, therefore changing the saved configs. FIXED-IN: 4.12.0 M +11 -0 ui/pageview.cpp M +1 -0 ui/pageview.h http://commits.kde.org/okular/afc74e76ef70abf70d993d4099000742080a8a85
the coments here seem to suggest that the ctrl-i shortcut is added in kde version 4.12.0 i am now running kubuntu 14.04 which run kde 4.13 and okular 0.19 and this patch still did not make it to it this is really a key feature, to be able to easily invert color i hope it gets more attentions and be re-opened actually unless its an issue in kubuntu, not pulling this in
The feauture is implemented. It just doesn't have a default shortcut, you can just assign the one you prefer for this really key feature
@Albert I propose Okular reconsiders the decision not to assign a default key and assigns one for the following reasons: - when new users want the feature, which is really way better with a shortcut, they have to do the work of setting it up. - users have to think themselves about a good way to dispose their many shourtcuts without conflict, while keeping them as mnemonic as possible. Just imagine if, say, Vim had no default shortcuts =) Okular devs are the ones who can make the best choice. If we add the shortcut by default we remove both of those burdens from new users. This is is specially important to attract new users who are not likely to search a lot for how to do things when using a new program. And if more advanced users want to change that shortcut, they can always do so.
If we add a shortcut to each action we run of of shortcuts. So no.
@Albert we could select the most useful ones until we run out =)
Yes, you can, there's a configure dialog for that.