Bug 172896 - Erratic behaviour of track detail editor
Summary: Erratic behaviour of track detail editor
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.0-beta
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords: needs_verification
Depends on:
Blocks:
 
Reported: 2008-10-15 21:45 UTC by Vesa Muhonen
Modified: 2009-12-09 11:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch to solve problem with year and track number (1.24 KB, patch)
2008-10-17 15:11 UTC, Andrey Esin 		Details
Patch to solve problem with year and track number (600 bytes, patch)
2008-10-17 15:13 UTC, Andrey Esin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vesa Muhonen 2008-10-15 21:45:14 UTC 
Version:           1.92 / beta 2 (using KDE 4.1.2)
OS:                Linux
Installed from:    SuSE RPMs

Editing the track details results in various cases of curious behaviour.

 -Editing any of the fields for a track has the additional effect of changing the track number to the year of the album.

 -Rating the whole album works fine if there is no composer set or the composer if the same for all tracks. However, if the composer differs between the tracks, then the composer tag is erased and the track number is set to same as the album year. If no composer was set, then that track is unaffected.

 -Writing any field for the whole album also additionally sets the track number to same value as year. As for the composer tag it's unaffected if it's the same for all tracks but erased if not.

Of course, I'll be happy to provide more info if necessary.
Comment 1 Andrey Esin 2008-10-17 15:11:47 UTC 
Created attachment 27968 [details]
Patch to solve problem with year and track number
Comment 2 Andrey Esin 2008-10-17 15:13:51 UTC 
Created attachment 27969 [details]
Patch to solve problem with year and track number

Sorry for last patch, it's incorrect....this is correct and solve problem wit changing year and track number
Comment 3 Andrey Esin 2008-10-17 15:15:32 UTC 
Comment on attachment 27968 [details]
Patch to solve problem with year and track number
Comment 4 Lydia Pintscher 2008-10-17 16:05:30 UTC 
Teo can you please have a look at the patch?

Andrey: Thanks a lot :)
Comment 5 Teo Mrnjavac 2008-10-17 17:23:51 UTC 
That's not my code but the patch makes sense.
Comment 6 Teo Mrnjavac 2008-10-17 17:45:44 UTC 
I committed the patch to amarok trunk.

SVN commit 872603 by mrnjavac:

Fix borked behavior of tag dialog with year and track number.
Thanks Andrey Esin for the patch.
This partially closes bug 172896.
Comment 7 Vesa Muhonen 2008-11-06 17:21:02 UTC 
As said, the patch seems to have fixed the issue with year and track number, but another issue still remains:

When editing the tags for whole album at once, like setting a disc number, comment and composer fields are deleted unless they contain the same string for all tracks.

Also, editing the details of a single track sets the disc number of that track to '0' if no disc number was specified.

ps. This is related to the original report, but should this be reported as separate bug?
Comment 8 Lydia Pintscher 2008-11-06 23:44:06 UTC 
I think there is another report about this already. If it is marked as fixed please reopen.
Comment 9 Vesa Muhonen 2008-11-07 22:41:20 UTC 
Couldn't find a previous bug concerning this. There was one concerning that the tags were not written to the file, but that's no the case here. The original bug report was a bit vague, contained separate issues and is partially fixed. Thus I opened a new report (bug 174574) for the comment / composer tags being deleted. I close this one as it was done after the partial fix.