Created attachment 27860 [details]
Screenshot showing the bug

*** Bug 172765 has been marked as a duplicate of this bug. ***

This isn't a Dolphin bug - it occurs in kdelibs/kio/file/kicondialog.cpp - or thereabouts :) I'll take a quick look now ...

The problem seems to occur because the KIconCanvas is set to have uniformItemSizes, whereas the icons it has in it are one of the stock icon sizes from the pre-rendered PNG icons (16,32,48, etc - all 48 by default) and a hard-coded size of 60 for the SVG icons, like the AIM etc icons.

I'm not sure how best to fix this, though - a start would be to get this hard-coded value of 60 removed and made adjustable (I'll do this tonight) and then find a means of finding the sizes of the non-scalable icons and scaling the SVGs to match.

About the text-clipping - this seems to be a rather odd decision by TT - in the text is only allowed to be as wide as the icon, even if the space between icons permits much more.  In KDE3, the text was allotted more space.  I don't know if this is configurable somehow or whether it would require a new delegate to be written.

Created attachment 27995 [details]
Candidate patch for this issue

Patch that:

1) Generalises some stuff and removes some magic numbers;

2) Assures that uniformIconSizes is honoured by adding padding to images that are too small;

3) Attempts to ensure that the speed/ memory impact of 2) is minimized and also that SVGs are scaled to a size consistent with the other icons;

4) Allots more horizontal space for the icon name - this is now dependent on the grid size, so if you feel it is still too cramped, the grid size should be enlarged.  I'll leave that decision up to someone with a better sense of aesthetics than me :)

CC'ing Carsten as he's the most active guy with his name in the file ;)

Bug 168458 and bug 174440 are duplicate of this bug.

*** Bug 168458 has been marked as a duplicate of this bug. ***

*** Bug 174440 has been marked as a duplicate of this bug. ***

*** Bug 177029 has been marked as a duplicate of this bug. ***

It seems fixed in kde 4.2 beta 1

Mh, I can still reproduce it with today 4.2 svn build. (But it happens when selecting icons for a "Places" item (like in Dolphin Places panel), This bug doesn't appear when selecting an icon for a folder inside a Plasma FolderView plasmoid.

(Also when selecting an icon for a "Places" item, inside Dolphin Places panel , the "System Icons:" combobox (to select an icon category) is empty, and only "applications" category icons are displayed, but this may be another bug)

Just type
kdialog --geticon action
in a terminal and you get a dialog where som icons are broken and where the buttons on the upper right do not expand with the text on it (i.e. translated messages are cut off if longer than the original text).

Ok, you are right. I only checked the bug description instructions. 

@Dario,

If you're building from SVN, can you test out my patch? If it works OK, I'll commit shortly.  You can play with the setGridSize(QSize(80,80)) size to increase the amount of text shown.

Created attachment 29224 [details]
Updated patch

Heh - the way of dealing with Groups vs explicit sizes with KIconLoader stuff is very confusing indeed :)

Dario has found that the old patch caused big problems when kdialog -geticon was called with incorrect parameters (you can find the set of supported parameters in here: http://websvn.kde.org/trunk/KDE/kdebase/apps/kdialog/kdialog.cpp?view=markup), so I've fixed this too as we should handle malformed input gracefully.

If people can test this new patch and if it doesn't cause any more problems, I'll commit.

Thanks!

SVN commit 895536 by sstjames:

Magic numbers--, pad icons to respect uniformItemSizes, choose appropriate size to reduce need for padding and ensure SVGs are scaled to a matching size, add delegate so that more space is allocated for text, increase grid (thus, text) size and initial dialog size.

BUG:172746

 M  +112 -10   kicondialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=895536