Bug 171615 - embedded browser tabs can not be closed using ctrl w
Summary: embedded browser tabs can not be closed using ctrl w
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: akregator konqueror plugin (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-24 22:29 UTC by Anders Lund
Modified: 2009-03-25 11:41 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Make Ctrl-W work (772 bytes, patch)
2009-03-22 19:42 UTC, Haakon Nilsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Lund 2008-09-24 22:29:21 UTC
Version:           1.3 (using 4.1.1 (KDE 4.1.1), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-16-generic

which I expect, since most KDE applications that can display more documents are kind enough to provide a way to close a one this way.
Comment 1 Christoph Lange 2008-11-10 23:06:20 UTC
What works for me in 1.3.3 (KDE 4.1.3) is:

1. press Ctrl+W twice, which focuses the close button in the tab bar
2. then I can press this button with Space
3. … and must remember not to hit Space for scrolling down the next article that I'm reading, as the close button will remain focused.
Comment 2 Kari Argillander 2009-01-09 21:49:59 UTC
I can confirm comment #1 

Comment 3 Andreas Ermler 2009-01-15 09:52:53 UTC
I still have this problem in KDE 4.2 RC1 (4.1.96) or Akregator 1.3.50.

Nothing happens when I hit CTRL+W once, when I hit it twice there's a notification:

"Ambigious shortcut detected
The key sequence 'Ctrl+W' is ambiguous. Use 'Configure Shortcuts'
from the 'Settings' menu to solve the ambiguity.
No action will be triggered."

But when I use "Configure Shortcuts" the only shortcut assigned to CTRL+W is "Close Tab".
Comment 4 km 2009-02-08 18:50:46 UTC
I can confirm this happens in akregator 1.4.0, KDE 4.2 (from opensuse factory rep.).
Comment 5 Haakon Nilsen 2009-03-22 19:42:22 UTC
Created attachment 32342 [details]
Make Ctrl-W work

It seems the problem was that the shortcut was being set twice; once in actionmanagerimpl.cpp and once in tabwidget.cpp. The attached patch removes the one in tabwidget.cpp. It also fixes a bug where Ctrl-W would stop working after being pressed when viewing the article list.
Comment 6 Frank Osterfeld 2009-03-24 22:32:53 UTC
SVN commit 944029 by osterfeld:

Fix tab-related shortcuts, including Alt+W
Issue spotted by Haakon Nilsen 
BUG: 171615


 _M            . (directory)  
 M  +14 -17    akregator/src/tabwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=944029
Comment 7 Frank Osterfeld 2009-03-25 11:41:41 UTC
SVN commit 944228 by osterfeld:

backport: 
CCBUG: 171615

r944038 | osterfeld | 2009-03-24 21:45:04 +0000 (Tue, 24 Mar 2009) | 2 lines

actually use frame var

------------------------------------------------------------------------
r944029 | osterfeld | 2009-03-24 21:32:52 +0000 (Tue, 24 Mar 2009) | 4 lines

Fix tab-related shortcuts, including Alt+W
Issue spotted by Haakon Nilsen



 M  +18 -18    tabwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=944228