Bug 171521 - in annotation mode allow access to the full size image
Summary: in annotation mode allow access to the full size image
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2008-09-23 15:23 UTC by eMBee
Modified: 2010-01-04 23:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to create new window from the Annotation Dialog (1.57 KB, patch)
2009-06-22 19:24 UTC, Alex
Details

Note You need to log in before you can comment on or make changes to this bug.
Description eMBee 2008-09-23 15:23:08 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

when annotating images, sometimes it is necessary to take a closer look at an image. it would be helpful if the original sized image could be accessed from the annotation view, maybe by clicking on the small image.
Comment 1 Jesper Pedersen 2009-06-11 22:04:03 UTC
Some hints to solve this bug:
* The preview area is the Annotation dialog is the class ImagePreview located in AnnotationDialog/ImagePreview.cpp
* You need to override QWidget::mousePressEvent() to be notified when the user clicks on the image, from there you need to open the viewer. See MainWindow/Window.cpp on how that is done if in doubt.
* The Viewer is in Viewer/ViewerWidget
Comment 2 Alex 2009-06-22 19:24:47 UTC
Created attachment 34747 [details]
Patch to create new window from the Annotation Dialog

Here is a patch to resolve this wish (171521) :)
Comment 3 Jesper Pedersen 2009-07-30 00:01:12 UTC
Some catch up from private emails:
Hassan Ibraheem wrote:
I haven't looked much into the Viewer code, so I don't know if it's a good
idea to open the viewer from the AnnotationDialog.
One issue I found: Right clicking the viewer instance and choosing "Show"
from the context menu closes the Annotation dialog and eventually crashes
KPA.
I think if we're going to use the viewer for this, we need to disable some
stuff or maybe have a simple viewer for this purpose. Perhaps we should use
ImagePreview for this instead.
I was thinking of how Juk shows album covers, click on the picture to show
the large version, but you can't do anything else, when you move your mouse
away the large version disappears.

Jesper added:
Indeed, I can reproduce that here. Alex, would you mind debugging why that is 
happening. (You may wish to start gdb using the -nograb option, to avoid Qt 
grapping the mouse, and then hitting a breakpoint, resulting in a deadlock).

If this turns out to be a dead end, you may have a look at the SimpleViewer in 
the importExport directory.

If you've identified the problem, but don't know how to solve it, try bouncing 
it against me.
Comment 4 Jesper Pedersen 2010-01-04 23:07:32 UTC
Hmm, I implemented something similar over Christmas that is already in trunk, which doesn't have the above defects. Sorry about not using your work Alex.