Bug 170827 - When importing classes or a project, hangs and eats resources
Summary: When importing classes or a project, hangs and eats resources
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-10 22:52 UTC by Ben Boeckel
Modified: 2020-01-11 11:16 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Boeckel 2008-09-10 22:52:34 UTC
Version:           2.1.0 (using KDE 4.1.0)
OS:                Linux
Installed from:    Fedora RPMs

When importing either classes or a project, Umbrello starts to eat up all of the CPU (well, one core) and nothing gets done.

I would suggest adding a progress bar for how far it is along with importing classes (if it's not already there and it hangs before that) to help the user know how long it's going to take. I can submit a wishlist item for that if wanted.
Comment 1 Nicola Brisotto 2009-01-09 09:49:39 UTC
I've found the same behaviour with:
Qt: 4.4.3
KDE: 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2))
Umbrello UML Modeller: 2.1.85
on Ubuntu 8.10

I'm trying to import the script directory from qt's git, commit 62f3b988c328726ad966a1a9c73b17544c76b336.


Comment 2 jordigh 2009-08-09 00:13:45 UTC
I can confirm this bug. Try it with the following code, for example:

     http://inversethought.com/hg/hgwebdir.cgi/rbf-ddm/
Comment 3 Philippe Le Gal 2009-11-14 18:17:26 UTC
I also confirme the bug but I've a suggestion about the problem : 
if the imported C++ header file contain only the necessary #include ... it works well. The bug come only if the .h contain unnecessary #include (C++ writing style bug)
Comment 4 jordigh 2009-11-14 18:56:18 UTC
Do you mean it happens if files #include each other?

In that case, the fix might be simple: make Umbrello obey #include guards.
Comment 5 Philippe Le Gal 2009-11-20 13:58:53 UTC
Hi (with some late...),

I've no time for the moment to dig the problem. I just noticed that if I 
suppress the unnecessary #include in the header file, class import works well.
I'll test soon if it was a recursive include.

Philippe

Le samedi 14 novembre 2009 18:56:20 jordigh@gmail.com, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=170827
> 
> 
> 
> 
> 
> --- Comment #4 from  <jordigh gmail com>  2009-11-14 18:56:18 ---
> Do you mean it happens if files #include each other?
> 
> In that case, the fix might be simple: make Umbrello obey #include guards.
>
Comment 6 Raúl 2014-06-04 10:34:43 UTC
Hi. I also noticed this bug in version 4.8.4 (Debian Wheezy), however I backported 4.13.1 and I'm unable to reproduce the problem. I think it'd be interesting if anyone could confirm this.

Regards,
Comment 7 Ralf Habacker 2014-06-04 19:02:43 UTC
(In reply to comment #2)
> I can confirm this bug. Try it with the following code, for example:
> 
>      http://inversethought.com/hg/hgwebdir.cgi/rbf-ddm/
link is outdated. I got: 
Mercurial repository not found
The specified repository "rbf-ddm" is unknown, sorry. Please go back to the main repository list page.
Comment 8 jordigh 2014-06-05 14:45:41 UTC
On Wed, 2014-06-04 at 19:02 +0000, Ralf Habacker wrote:
> https://bugs.kde.org/show_bug.cgi?id=170827

> >      http://inversethought.com/hg/hgwebdir.cgi/rbf-ddm/
> link is outdated. I got: 

Got moved here:

    http://inversethought.com/hg/kwantix

- Jordi G. H.
Comment 9 Oliver Kellogg 2014-06-07 06:19:35 UTC
(In reply to comment #8)
> 
> Got moved here:
>     http://inversethought.com/hg/kwantix

Thanks.
I downloaded kwantix-b3bf4ac981ec.tar.bz2 of 2014-06-05 and did
  Code ->Import Project...
on the src/include directory. That worked without any noticeable delay.
Comment 10 Ralf Habacker 2015-03-10 20:51:19 UTC
(In reply to Oliver Kellogg from comment #9)
> I downloaded kwantix-b3bf4ac981ec.tar.bz2 of 2014-06-05 and did
>   Code ->Import Project...
> on the src/include directory. That worked without any noticeable delay.
which version do you have used ? 
With version 2.12.80 the cpp parser has been upgraded to kdevelop version 3.5 and may have fixed the issue.
Comment 11 Oliver Kellogg 2020-01-11 11:16:49 UTC
(In reply to Ralf Habacker from comment #10)
> (In reply to Oliver Kellogg from comment #9)
> > I downloaded kwantix-b3bf4ac981ec.tar.bz2 of 2014-06-05 and did
> >   Code ->Import Project...
> > on the src/include directory. That worked without any noticeable delay.
> which version do you have used ? 
> With version 2.12.80 the cpp parser has been upgraded to kdevelop version
> 3.5 and may have fixed the issue.

I guess the cpp parser update fixed the issue.
To double check, I tried again using the current release/19.12 branch and the files are imported within one to two seconds.