Bug 169772 - KDM oxygen default theme "scale" error
Summary: KDM oxygen default theme "scale" error
Status: RESOLVED FIXED
Alias: None
Product: kdm
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdm bugs tracker
URL:
Keywords:
: 176432 186147 203710 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-25 13:29 UTC by Andreas
Modified: 2016-12-26 15:07 UTC (History)
13 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
oxygen kdm theme patch (542 bytes, patch)
2008-10-25 10:45 UTC, palo revak
Details
Oxygen KDM theme on KDE 4.3, with a 4:3 aspect ratio. (114.47 KB, image/png)
2009-08-07 17:12 UTC, Ivo Anjo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas 2008-08-25 13:29:04 UTC
Version:            (using KDE 4.1.0)
OS:                Linux
Installed from:    SuSE RPMs

Hello,
I'm proud to call me an Acer Aspire One A150L User and I installed a fresh openSUSE 11.0 and the latest "stable" KDE 4.1 packages. I encountered a little error in the default kdm4 theme oxygen.

Usually thiese settings in the oxygen.xml file should scale the image:

<greeter id="theme">
        <style font="Sans 12" window-text-color="#C7C7C7"
               base-color="#C7C7C7" alternate-base-color="#666666"
               text-color="#000000" disabled-text-color="#808080"/>
        <item type="svg" id="background" background="true">
                <normal file="background.svg"/>
                <pos anchor="c" x="50%" y="50%" width="scale" height="100%"/>
        </item>


But the width="scale" doesn't work, I get black borders at the left and right side. So I hardcoded my resolution (1024x600) and everything works fine.

I think this would be nice to be fixed.

Thanks a lot and especially for the nice oxygen work.
Comment 1 palo revak 2008-10-25 10:45:43 UTC
Created attachment 28129 [details]
oxygen kdm theme patch

fixes background drawing on 16:9 displays
Comment 2 palo revak 2008-10-25 10:55:27 UTC
this problem is on all display with 16:9 (or more) wide screen.
on my laptop isn't border paint and has random data. it doesn't look nicely.

the patch correct it.
plese add the patch to kde4.1.x and kde 4.2

thanks
Comment 3 The Marauder 2008-11-03 23:22:42 UTC
I've the same problem with Debian SID and Kubuntu 8.04/8.10 with my notebook MSI WIND u100x in the same resolution 1026x600.
replace "scale" by "100%" always correct the problem.
Comment 4 Alex Dioso 2008-11-26 01:30:11 UTC
Same problem on MSI Wind with Gentoo and KDM 4.1.3.  As Marauder noted, replacing "scale" with "100%" fixes the problem.
Comment 5 Oswald Buddenhagen 2008-11-29 13:54:52 UTC
*** Bug 176432 has been marked as a duplicate of this bug. ***
Comment 6 Iuri Fiedoruk 2009-01-16 13:49:05 UTC
Had the same issue with my Asus eeePC 701. width="100%" indeed fixes the problem.
Comment 7 George Moody 2009-01-16 21:14:07 UTC
Using Kubuntu KDE4.2 RC1 packages, have the same problem on a Advent 4211 screen size 1024x600, but not on a wide screen 1680x1050 LCD monitor so the issue may relate to the rootimage code within kdm not necessarily the xml file?
Comment 8 Jeffrey 2009-01-28 16:06:39 UTC
Works for me to edit that file on Debian Sid/Experimental with KDE 4.2 on my EeePC 701.
Comment 9 Caleb Cushing 2009-01-31 02:38:21 UTC
4.2.0 and we shouldn't have to edit files to get it to work, I don't have black I've raw screen corruption at the edges. I don't think I have this problem in opensuse though... but they change things from default kde.
Comment 10 Andreas 2009-01-31 11:38:58 UTC
Yes, 4.2.0 and the same problem, if I change scale to 100% everything looks fine.
Is it so difficult to change the value or is there a reason to have the value "scaled" in it?
The Bug is 5 months old and for everyone who has widescreen resolutions it's annoying.

And I can confirm the funny artefacts, didn't have them with 4.1.x.
Comment 11 Juan Pablo Morelli 2009-02-06 14:52:31 UTC
I have this problem in my Acer Aspire One with kde 4.2(kubuntu 8.10).
Editing /usr/share/kde4/apps/kdm/themes/oxygen/oxygen.xml and changing:

...<pos anchor="c" x="50%" y="50%" width="scale" height="100%"/> ...

with

...<pos anchor="c" x="50%" y="50%" width="100%" height="100%"/>... 

fix my problem !!! Thanks.
Comment 12 Benson Tsai 2009-02-07 19:44:45 UTC
*** This bug has been confirmed by popular vote. ***
Comment 13 Riccardo Iaconelli 2009-02-24 19:04:53 UTC
SVN commit 931040 by ruphy:

Use 100% instead of scale - fix kdm background for wide widescreens. No
regressions reported so far.

BUG: 169772

CCMAIL: urs@oxygen-icons.org

Signed-off-by: Riccardo Iaconelli <riccardo@kde.org>

 M  +1 -1      oxygen.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=931040
Comment 14 Caleb Cushing 2009-03-09 01:28:07 UTC
what version of kde is/will the fix be in?
Comment 15 Oswald Buddenhagen 2009-03-15 12:27:51 UTC
*** Bug 186147 has been marked as a duplicate of this bug. ***
Comment 16 Oswald Buddenhagen 2009-03-15 12:51:15 UTC
i find this "fix" somewhat funny, given that the problem resulted directly from attempting to keep the background's aspect ratio constant. failure to do so was a much complained about problem when the original theme was committed (though no bug seems to have been filed).
this needs a somewhat more sophisticated approach. i wonder whether i should introduce an explicit "maxpect" mode like the regular background generator has, or whether this should be approached by generic conditionals. the former potentially opens the door for feature creep into the theme format, the latter requires duplication in essentially every theme.
Comment 17 Jonathan Thomas 2009-08-05 19:22:08 UTC
Same problem again with the Air theme. :(
Comment 18 Jeffrey 2009-08-05 19:33:09 UTC
> replacing "scale" with "100%" fixes the problem.
Why isn't this just implemented immediately if it is fixing this problem for everyone?
Comment 19 Ivo Anjo 2009-08-07 17:12:19 UTC
Created attachment 35966 [details]
Oxygen KDM theme on KDE 4.3, with a 4:3 aspect ratio.

Now on KDE 4.3 the background is stretched on 4:3 displays, making it look weird.
The attached screenshot shows kdm at 640x480, but this happens with any resolution with 4:3 or a similiar ratio.
Comment 20 Riccardo Iaconelli 2009-08-07 21:01:37 UTC
ossi, i think that the former fix is really the way to go.

And, about my fix, better stretch than show garbage. :-)
Unless you can simply make sure that you're painting a black square under everything (I assume the garbage is introduced by trying to paint a transparent area).
Comment 21 Oswald Buddenhagen 2009-08-09 11:05:48 UTC
well, black-padding would be quite trivial with the existing format, but it would look rather silly.

hmm, so i'll implement maxpect somehow.

but there is also a third option: add a special background item type which links in a plasma-compatible background definition. this should be linked by the splash screen as well, and of course be directly used by plasma itself. this would not only ensure uniformity, but also reduce the disproportional waste of disk space by duplicated artwork.
see also bug 172857. and ask davide.
Comment 22 Riccardo Iaconelli 2009-08-09 15:22:53 UTC
agreed, that'd be the really best option.
note that plasma (I co-designed that code) for backgrounds tries to calculate the closest resolution possible, and in case it can't find a perfect fit, falls back on scale&crop. It would be good to be consistent here.

Ah, also, just to ensure we show less crap as possible, can you implement black-padding and backport it to 4.3? At least is less annoying than random garbage for whoever uses a weird resolution. :-)
Comment 23 Oswald Buddenhagen 2009-08-09 17:40:40 UTC
implemented scalemode={free|fit|crop} in trunk (r1009279) and fixed the themes (r1009280). will sneak in this feature into the 4.3 branch once it is a bit tested.
Comment 24 Riccardo Iaconelli 2009-08-09 21:56:44 UTC
you rock, you really do :-)

now i suppose we can close the bug...
Comment 25 Oswald Buddenhagen 2009-09-04 22:20:02 UTC
*** Bug 203710 has been marked as a duplicate of this bug. ***
Comment 26 jcb1985 2009-09-06 11:06:51 UTC
is this bug supposed to be fixed in 4.3.1 ?
I have a screen with a resolution of 1920x1080 and I still see this bug with 4.3.1 (kubuntu packages on jaunty)
Comment 27 BRULE Herman 2009-09-06 11:19:24 UTC
No fixed for my in 4.3.1
Comment 28 Oswald Buddenhagen 2009-09-13 11:10:33 UTC
SVN commit 1022821 by ossi:

fix the themes' background images' aspect ratio

backport of r1009280 & r1011924

CCBUG: 169772


 M  +2 -2      oxygen-air/oxygen-air.xml  
 M  +2 -2      oxygen/oxygen.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022821
Comment 29 caulier.gilles 2016-12-26 15:07:38 UTC
*** Bug 203710 has been marked as a duplicate of this bug. ***