Bug 169012 - keys on Numpad not work when NumLock off in KDE4.1 Konsole
Summary: keys on Numpad not work when NumLock off in KDE4.1 Konsole
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
: 165169 175969 200663 213579 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-13 05:05 UTC by pan shi zhu
Modified: 2018-03-25 09:35 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
This patch solves the bug 169012 (1011 bytes, patch)
2009-04-15 10:21 UTC, pan shi zhu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pan shi zhu 2008-08-13 05:05:03 UTC
Version:            (using KDE 4.1.0)
Installed from:    Compiled From Sources
OS:                Linux

When numlock is off, the numpad can be used for arrow keys and home/end/pgup/pgdn. This works perfectly in KDE 3.5.9 Konsole.

But in KDE 4.0.5 and KDE 4.1.0 the numpad does not work at all, press the arrow key and PgUp/PgDn has no effect.

I had tested under the following platform:
ubuntu 8.04 + KDE3.5.9, numlock off, numpad works great.
ubuntu 8.04 + KDE4.0.5, numlock off, numpad does not work.
archlinux + KDE 4.1.0, numlock off, numpad does not work.
Comment 1 Alex Fomenko 2008-12-26 19:16:02 UTC
I confirm this on Kubuntu 8.10 + KDE 4.1.3

Also the keys work when shift is pressed
Comment 2 Ben Aceler 2008-12-27 11:11:36 UTC
Still here on KDE 4.1.3
Comment 3 Renan Inácio 2008-12-31 04:50:14 UTC
KDE4.2 Beta 2 on Kubuntu also have this bug.
You can't use Shift+PageUp if PageUp is actually KP_Prior instead of Prior.
Also, KP_ keys get incorrectly passed to applications like "less", for example when searching for a string on "man". You can't use numbers of keypad (KP_1, KP_2, etc) with Numlock on, and neither use KP_Prior or KP_Next to scroll.
Comment 4 Costin Grigoras 2009-02-02 23:33:53 UTC
*** This bug has been confirmed by popular vote. ***
Comment 5 Costin Grigoras 2009-02-02 23:37:23 UTC
I can confirm the bug is still there in 4.2.0 / Ubuntu 8.10.

Home, End, PgUp, PgDn, Insert, Delete - don't do anything
Shift Home -> 'H'
Shift End -> 'F'
Shift Del -> "2~"
Shift Ins -> really does paste, just like the other Ins key that works by itself
Shift PgUp, PgDn - nothing
Comment 6 Kurt Hindenburg 2009-02-03 06:48:14 UTC
*** Bug 175969 has been marked as a duplicate of this bug. ***
Comment 7 Kurt Hindenburg 2009-02-03 06:50:55 UTC
*** Bug 165169 has been marked as a duplicate of this bug. ***
Comment 8 pan shi zhu 2009-02-04 04:11:44 UTC
Bug 175969 and bug 165169 is not exactly the same, let me summarize:

Bug 169012 saids the keypad 1-9 does not work when numlock off. (works in KDE3 not in KDE4)
Bug 175969 saids the keypad 0 does not work when numlock off. (works in KDE3 not in KDE4)
The above two bugs saids keypad should work as arrow keys and Home/Pgdn/Insert when numlock off.

Bug 165169 saids when numlock off the keypad works in KDE3 but not as desired. e.g. the keypad 8 is up arrow, which should have a different keycode from the up arrow key so that terminal program can distinguish them. It saids nothing about KDE4 since keypad does not work when numlock off.

Comment 9 Kurt Hindenburg 2009-02-04 05:05:53 UTC
Thanks for the summary.  KDE3 is no longer supported.  The code has changed too much in KDE4.  So, these reports all seem to say that in KDE4 w/ numlock off, the keypad doesn't work as it should.
Comment 10 Costin Grigoras 2009-02-04 09:10:22 UTC
Yes, numpad keys with numlock off don't work as expected.

I'm using Konsole a lot, and it has two weird behaviors:
- in Input = Default (XFree 4) the numpad keys with numlock off don't work at all. Home, End, PgUp, PgDn are dead. Shift + the keys works, but only in MC. In plain shell there is no scrolling, no line navigation.

- with Input = Linux console, the numpad keys work if used without Shift, but F* keys produce crap like [A, [B ... Shift+numpad produces the equivalent numbers.

Also, Shift+Home/End to select text in Firefox or anything else doesn't work. It's a generalized mess :)
Comment 11 pan shi zhu 2009-04-15 10:16:53 UTC
I've provided a patch for this: make Keypad works when NumLock off.

I had tested it in KDE 4.2.2 and it solve the problem.

patch is diff -u format, changed file is :

kdebase/apps/konsole/data/keyboard-layouts/default.keytab
Comment 12 pan shi zhu 2009-04-15 10:21:42 UTC
Created attachment 32853 [details]
This patch solves the bug 169012

I had tested in Normal cursor mode and Application cursor mode.

the changed file is in kdebase/apps/konsole/data/keyboard-layouts/
Comment 13 pan shi zhu 2009-05-18 02:45:34 UTC
Bump, any comment about my patch? 

Anyone tested on KDE 4.3 beta?
Comment 14 Robert Knight 2009-05-18 12:02:21 UTC
No, the patch hasn't been tested yet.  Apologies for that.  It might be worth posting it on reviewboard.kde.org as well since it will then appear in the queue with other patches waiting to be merged.
Comment 15 ms 2009-06-20 21:51:11 UTC
it's work.
Tested on Sabayon Linux KDE 4.2.4 Konsole v.2.2.3.
Thanks pan shi zhu.
Comment 16 pan shi zhu 2009-06-29 09:07:29 UTC
It seems to work so far, I tried to submit to reviewboard but it complains about "Unable to parse diff revision header '2009-04-15 16:10:25.000000000 +0800'", I'm using diff -u, What is the desired diff format for reviewboard?


base diff path is: kdebase/apps/konsole/data/keyboard-layouts
patch is pointed to my patch file. 
Is that the correct input for reviewboard?


Anyway, my patch is simple, anyone having a kde svn account please review my patch and submit it. Thanks.
Comment 17 Vsevolod Krishchenko 2009-07-19 19:03:31 UTC
*** Bug 200663 has been marked as a duplicate of this bug. ***
Comment 18 Kurt Hindenburg 2009-08-09 17:02:01 UTC
SVN commit 1009268 by hindenburg:

Fix to allow keys on numpad to work with numlock off.

Thanks to pan shi zhu for patch.

BUG: 169012


 M  +21 -0     default.keytab  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1009268
Comment 19 pan shi zhu 2009-11-11 02:46:41 UTC
Where does this commit go?

I upgraded to the KDE 4.3.2 and found that this patch is not there.
Comment 20 Ahmad Samir 2018-03-25 09:35:43 UTC
*** Bug 213579 has been marked as a duplicate of this bug. ***