Bug 168874 - ktorrent asks before overwriting old logfile
Summary: ktorrent asks before overwriting old logfile
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-10 21:54 UTC by Christian Boltz
Modified: 2013-07-07 08:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Boltz 2008-08-10 21:54:08 UTC
Version:           KTorrent 3.0.2 (using KDE 4.0.5)
Installed from:    SuSE RPMs

(Initially reported as https://bugzilla.novell.com/show_bug.cgi?id=406634)

Ktorrent asks the user something like "do you really want to overwrite the old
log while logrotation?"  OK, it doesn't ask this way, but it displays the
normal "overwrite file?" dialog saying that ~/.kde4/share/apps/ktorrent/log-1
already exists and asks if I want to overwrite it with
~/.kde4/share/apps/ktorrent/log.

This behaviour is annoying. Logrotation should be done silently.

Screenshot: https://bugzilla.novell.com/attachment.cgi?id=226144
Comment 1 Joris Guisson 2008-08-11 08:36:38 UTC
This is a bug in KIO : when moving the files, ktorrent will use KIO::file_move and will pass the KIO::Overwrite flag which should make sure this dialog is never shown. (see libbtcore/util/autorotatelogjob.cpp in the ktorrent code)
Comment 2 David Faure 2008-08-11 11:26:04 UTC
SVN commit 845118 by dfaure:

unit test for KIO::file_move with KIO::Overwrite, passes
CCBUG: 168874
I think there's no kio bug; please check that you are passing -1 as the third argument and the flags in the fourth argument.
(Yes I know, that API could be better -- too late)


 M  +14 -0     jobtest.cpp  
 M  +2 -0      jobtest.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=845118
Comment 3 Dawit Alemayehu 2013-06-15 20:32:44 UTC
see comment #2.
Comment 4 Joris Guisson 2013-07-07 08:14:59 UTC
Logrotation is done silently and has always been done silently