Bug 167496 - Name not displayed if addressbook link is broken
Summary: Name not displayed if addressbook link is broken
Status: CONFIRMED
Alias: None
Product: kopete
Classification: Applications
Component: Addressbook integration (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-26 22:23 UTC by William Hilton
Modified: 2021-03-09 22:40 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to solve the reported issue (1.42 KB, patch)
2008-12-23 14:34 UTC, Andrea Cimino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William Hilton 2008-07-26 22:23:03 UTC
Version:           0.50.80 Using KDE 4.1.60 (kde-nightly-kdenetwork_20080725+svn837873-0neon1_i386.deb) (using Devel)
Installed from:    Compiled sources
OS:                Linux

If a contact's Display Name Source is set to "Use addressbook name", and the contact resource containing the Kopete contact's name is disabled, Kopete displays the contact without a name. A preferable behavior would be: if the address book link for a contact is broken, default to showing the name that would be shown if "From contact:" was enabled, with the text "(Broken Address Book Link)" in parentheses after the name to let the user know they should fix their address book. The Display Name Source option should not change it's setting, in case the addressbook becomes available again. (E.g. don't repeat Bug 139307 from KDE 3.)

Tested with 0.50.80 (Using KDE 4.1.60, Kubuntu package kde-nightly-kdenetwork_20080725+svn837873-0neon1_i386.deb in the KDE-nightly Neon repository). 

Test case:
Open Kopete. Right click on a contact and select Properties. Under Address Book Link click "Change". Create an addressbook entry for the contact. Under Display Name Source, select "Use addressbook name (needs addressbook link)". Now, open System Settings, and from the Advanced tab open KDE Resources. Click "Add..." and add a new file resource. Select the new resource and click "Use as Standard". Then, uncheck the original file resource and hit "Apply". (Now the addressbook will no longer contain the contact Kopete needs.) Restart Kopete. The contact appears without a name; this is undesirable and makes the contact hard to find. In System Settings > KDE Resources, recheck the file resource containing the contact, hit "Apply", and restart Kopete. The contact is displayed with the correct name again.
Comment 1 Andrea Cimino 2008-12-23 14:34:21 UTC
Created attachment 29577 [details]
Patch to solve the reported issue

This should solve the issue reported. If the KABC source doesn't work,
fallback to the normal source, reporting that KABC has some problems.
Comment 2 Matt Rogers 2008-12-25 21:09:38 UTC
in the patch "maybeNameFromKABC.isNull()" should be "maybeNameFromKABC.isEmpty()" instead, otherwise this looks fine. I'm getting clarification from the release-team on the new string right now, and if we can add a new string, then we can commit this for KDE 4.2
Comment 3 Marvin 2010-04-25 17:56:31 UTC
this bug still exists and is not very user friendly! why is the patch not applied?

there is another problem if the link to the address book is broken. at the moment it switches back to the image from the contact if address book image was previously selected, which is not the problem. but if the address book becomes available again, it does not switch back to the image from the address book contact. so, the must manually reassign the images for all contacts.
Comment 4 Justin Zobel 2021-03-09 22:40:48 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.