Bug 165491 - Kleopatra: Bugs in process for create new certificates.
Summary: Kleopatra: Bugs in process for create new certificates.
Status: VERIFIED FIXED
Alias: None
Product: kleopatra
Classification: Applications
Component: general (show other bugs)
Version: outdated (old bug dump)
Platform: Compiled Sources Microsoft Windows
: HI normal
Target Milestone: ---
Assignee: Marc Mutz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-01 16:28 UTC by Emanuel Schütze
Modified: 2017-05-15 11:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Export secret key dialog with passhrase charset. (10.76 KB, image/png)
2008-07-21 15:25 UTC, Emanuel Schütze
Details
Secret Key Export Error dialog (10.56 KB, image/png)
2008-07-21 15:26 UTC, Emanuel Schütze
Details
Kleopatra log file of export error (23.75 KB, text/plain)
2008-07-21 15:27 UTC, Emanuel Schütze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuel Schütze 2008-07-01 16:28:49 UTC
Version:           1.9.3beta RC (using Devel)
Installed from:    Compiled sources
OS:                MS Windows

Create new X.509 certificate:

* Dialog "Enter Details"
   - No email validation check

* Dialog "Key pair successfully created"
-> Save Request To File...
   - Error in info message "Successfully wrote request to %1(I18N_ARGUMENT_MISSING)."
-> Send Request by email
   - String in CC line: "&bbc="
   - No attachment with request information!

All dialogs are in English only.

Tested with Gpg4win 1.9.3 beta RC (=svn833)
Comment 1 Marc Mutz 2008-07-01 23:38:50 UTC
SVN commit 826853 by mutz:

i18n fix
CCBUG:165491

 M  +2 -1      newcertificatewizard.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=826853
Comment 2 Marc Mutz 2008-07-02 11:48:46 UTC
Fixed in rev. 827104.
Comment 3 Emanuel Schütze 2008-07-08 17:39:34 UTC
* German translation is still missing.
* OpenPGP key created:
  - "make a backup" dialog: file type (p10?) is missing, filter useful
  - "send by mail": "&bbc=" still in CC line + no attachment!
* X.509 email validation check not 100% correct: Fill CN+O+C correctly. THEN fill a correct mail address in the EMAIL field. Press TAB-Key. Next-Button will _not_ be active. You have to change one of the other fields and then press Tab-key to get a active Next Button. 
* X.509 cert created:
  - "save request" dialog: file type filter useful
  - "send by mail": "&bbc=" still in CC line + no attachment! 
Comment 4 Emanuel Schütze 2008-07-21 15:23:13 UTC
1st Kleo run only:
- "make a backup" of created openPGP key
-> new export dialog with passphrase charset list (see screenshot)
-> Choose file name -> OK
-> "Secret Key Export Error: [..] The output from C:\Programme\GNU\GnuPG\gpgsm.exe was: gpgsm: key not found: Ungltiger Name"
(more: see attached kleo log file)

After restart Kleo: export works fine!
Comment 5 Emanuel Schütze 2008-07-21 15:25:20 UTC
Created attachment 26299 [details]
Export secret key dialog with passhrase charset.
Comment 6 Emanuel Schütze 2008-07-21 15:26:09 UTC
Created attachment 26300 [details]
Secret Key Export Error dialog
Comment 7 Emanuel Schütze 2008-07-21 15:27:15 UTC
Created attachment 26301 [details]
Kleopatra log file of export error
Comment 8 Marc Mutz 2008-07-22 13:03:05 UTC
> * German translation is still missing. 

This is ongoing work, not a bug.

> * OpenPGP key created: 
>   - "make a backup" dialog: file type (p10?) is missing, filter useful 

.asc or .gpg, not .p10. Will enforce. Filters are useful only for Open filedialogs, not Save ones, no?

>   - "send by mail": "&bbc=" still in CC line + no attachment!

We're using the platform mail invokation. What mail program is that? Very likely not a Kleo bug.

> * X.509 email validation check not 100% correct: Fill CN+O+C correctly.
> THEN fill a correct mail address in the EMAIL field. Press TAB-Key.
> Next-Button will _not_ be active. You have to change one of the other fields
> and then press Tab-key to get a active Next Button.

Confirmed.

> * X.509 cert created: 
>   - "save request" dialog: file type filter useful 
>   - "send by mail": "&bbc=" still in CC line + no attachment! 

Ok, cf. OpenPGP.
Comment 9 Marc Mutz 2008-07-22 13:53:04 UTC
SVN commit 836498 by mutz:

Fix missing completeChanged() on emailLE->textChanged()
CCBUG:165491

 M  +5 -1      newcertificatewizard.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=836498
Comment 10 Emanuel Schütze 2008-07-22 14:06:23 UTC
> .asc or .gpg, not .p10. Will enforce. 
> Filters are useful only for Open filedialogs, not Save ones, no? 
Filter are really useful for all save dialogs! Every win application provides it. And the Kleo export certificate dialog too.

> We're using the platform mail invokation. 
> What mail program is that? Very likely not a Kleo bug. 
Outlook 2003.
Comment 11 Marc Mutz 2008-07-22 14:43:35 UTC
SVN commit 836512 by mutz:

Use QDesktopService::openUrl(), which seems much more reliable than KToolInvokation::invokeMailer() on Windows.
CCBUG:165491

 M  +24 -11    newcertificatewizard.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=836512
Comment 12 Emanuel Schütze 2008-08-05 10:14:15 UTC
Better, but not completely fixed:
- create pgp key:
  * attachment still missing if send email
  * filetype of saved backup key missing
  * filetype filter in save backup key dialog missing

- create smime certificat:
  * attachment still missing if send email
  * save request: strange <para> and <filename> strings
  * filetype filter in save request dialog missing
Comment 13 Marc Mutz 2008-08-06 18:22:47 UTC
SVN commit 843175 by mutz:

Enforce use of the correct extension
CCBUG:165491

 M  +24 -0     exportsecretkeydialog.cpp  
 M  +1 -0      exportsecretkeydialog.h  
 M  +38 -0     exportsecretkeydialog.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=843175
Comment 14 Marc Mutz 2008-08-06 18:24:37 UTC
SVN commit 843176 by mutz:

Fix missing attachment url->filename conversion
CCBUG:165491

 M  +16 -3     newcertificatewizard.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=843176
Comment 15 Marc Mutz 2008-08-06 18:28:54 UTC
> Better, but not completely fixed: 
>  - create pgp key: 
>   * attachment still missing if send email 

Fixed, see above.

>   * filetype of saved backup key missing 

Implemented, see above.

>   * filetype filter in save backup key dialog missing 

Implemented, see above.

> - create smime certificat: 
>   * attachment still missing if send email 

Fixed, see above.

>   * save request: strange <para> and <filename> strings 

Works For Me.

>   * filetype filter in save request dialog missing 
 
Fixed, see above.

Closing.

Please only report one issue per bug, unless they're the same bug. Thanks.