Bug 165087 - invalid firstFrameOffset with no ID3v2 tag
Summary: invalid firstFrameOffset with no ID3v2 tag
Status: RESOLVED WORKSFORME
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-27 10:38 UTC by Jim Martin
Modified: 2023-01-07 05:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Martin 2008-06-27 10:38:30 UTC
Version:            (using Devel)
Installed from:    Compiled sources
Compiler:          MSVC 2005 
OS:                MS Windows

I have encountered problems in getting the correct firstFrameOffset for MPEG files that don't have an ID3v2 tag.

In MPEG::File::firstFrameOffset(), it has:

  if(ID3v2Tag())
    position = d->ID3v2Location + ID3v2Tag()->header()->completeTagSize();

I think the problem is caused by the creation of ID3v1 and ID3v2 tags at the end of MPEG::File::read.  Because the tag is created if it doesn't exist in the file, this sets the starting point of the search to 9 or -1 (d->ID3v2Location) + 10 (completeTagSize() for an empty tag).

There are a few different ways to fix this but I think either checking if d->ID3v2Location >= 0 or checking if d->hasID3v2 is true would solve the problem.
Comment 1 Theofilos Intzoglou 2008-08-07 15:18:27 UTC
Another problem that occurs with those two lines at the end of MPEG::File::read is that I cannot open a file without creating an ID3v1 tag. This is useful for an app I'm developing. This didn't happen in taglib v1.4. Thanks in advance!
Comment 2 Scott Wheeler 2008-08-07 15:59:31 UTC
Please file a separate bug report for separate issues.  Bugs are like TO-DO items when doing a release; as soon as they're fixed they get closed and not looked at again.  I don't always reread all of the comments when going through them.
Comment 3 Andrew Crouthamel 2018-11-02 04:28:50 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Andrew Crouthamel 2018-11-16 02:48:05 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 5 Justin Zobel 2022-12-08 23:51:11 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 6 Bug Janitor Service 2022-12-23 05:22:01 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2023-01-07 05:24:43 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!