Bug 164847 - Option for turning off overlay buttons on thumbnails
Summary: Option for turning off overlay buttons on thumbnails
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: junior-jobs
: 196542 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-24 19:05 UTC by Maciej Pilichowski
Modified: 2018-02-14 18:47 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: KDE Applications 18.04


Attachments
Toolbar reapper after FS mode (1.01 KB, patch)
2008-06-27 08:36 UTC, Ilya Konkov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2008-06-24 19:05:18 UTC
Version:            (using Devel)

option for turning off toolbox

When you browsing images there is a toolbox flying around (fullscreen, rotate left, rotate right). Please, provide option to turn this off, I cannot see images because of it.
Comment 1 Ilya Konkov 2008-06-27 08:07:27 UTC
It doesn't fly by default. Anyway you can disable it by right clicking on menu and then clicking on "Main Toolbar". Though it will reappear after fullscreen mode.

screenshot:
http://img59.imageshack.us/img59/1416/gwenviewbug164847lb2.png
Comment 2 Ilya Konkov 2008-06-27 08:36:59 UTC
Created attachment 25646 [details]
Toolbar reapper after FS mode

This will solve fullscreen issue.
Comment 3 Maciej Pilichowski 2008-06-27 09:17:47 UTC
Not toolbar, but toolbox (*) -- tiny widget flying around. 

(*) I don't know the proper names for a lot of mechanism because there so many of them, sorry
Comment 4 Ilya Konkov 2008-06-27 10:59:10 UTC
Sorry, my bad. I need to read more carefully.
Comment 5 Jekyll Wu 2012-01-03 02:55:17 UTC
*** Bug 196542 has been marked as a duplicate of this bug. ***
Comment 6 null 2018-01-31 00:07:43 UTC
I'm undecided on this one. I can see why someone would find the buttons annoying. On the other hand, adding yet another config option for something we got only very few complaints about might not be worth it. After all, in Dolphin you have similar buttons to select files.
Comment 7 Nate Graham 2018-01-31 00:08:52 UTC
You can turn those buttons off in Dolphin! :) I do, in fact. I'd be in favor of a button to turn the overlay buttons off here in Gwenview (even though I personally don't mind them).
Comment 8 null 2018-01-31 00:16:20 UTC
Indeed ("Show selection marker" – TIL).

I think then I would be fine with having the config option.

Perhaps this bug is a good case to point future contributors to, as it is easy with very tangible results? (hint, hint ;)
Comment 9 Nate Graham 2018-01-31 00:29:01 UTC
I think I follow your drift, Henrik... ;)
Comment 10 null 2018-02-14 17:24:47 UTC
Git commit 4a87ed952ec209d4407fad664a76a2e1afd59b95 by Henrik Fehlauer, on behalf of Huon Imberger.
Committed on 14/02/2018 at 17:24.
Pushed by rkflx into branch 'master'.

Add options to disable some/all buttons when hovering over thumbnails

Summary:
Adds three options:

  1) Show all (previous behaviour, now default)
  2) Show only selection buttons (hide fullscreen and rotate buttons in Browse View)
  3) Hide all buttons

This option affects Browse View, Image View Thumbnail Bar, and the Importer tool `gwenview_importer`.

Reviewers: rkflx, ngraham

Reviewed By: rkflx, ngraham

Subscribers: ngraham

Differential Revision: https://phabricator.kde.org/D10421

M  +25   -5    app/browsemainpage.cpp
M  +7    -0    app/configdialog.cpp
M  +1    -0    app/configdialog.h
M  +60   -16   app/generalconfigpage.ui
M  +1    -1    app/viewmainpage.cpp
M  +12   -1    importer/thumbnailpage.cpp
M  +10   -0    lib/gwenviewconfig.kcfg
A  +48   -0    lib/thumbnailactions.h     [License: GPL (v2)]
M  +2    -1    lib/thumbnailview/thumbnailbarview.cpp

https://commits.kde.org/gwenview/4a87ed952ec209d4407fad664a76a2e1afd59b95
Comment 11 null 2018-02-14 17:33:39 UTC
> Added
> Version Fixed In|                            |KDE Applications 18.04
Is there a way to automate this? At least https://www.kde.org/announcements/ is able to do it, maybe we could bend the commit hooks to do something similar? (It's a user-visible thing only anyway.)
Comment 12 Nate Graham 2018-02-14 18:29:13 UTC
Yes, Phabricator will add it automatically if you include the "FIXED-IN:" tag to the revision's Summary section:

FIXED-IN: KDE Applications 18.04

See also:
- https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
- https://techbase.kde.org/Development/Git/Configuration#Commit_Template
Comment 13 null 2018-02-14 18:33:06 UTC
I know, but that's not what I meant. In theory the commit hooks should be able to figure out on their own (based on the branch and the next release coming up as determined by various metadata and/or CMake version magic) what the next release is going to be called.

I'm too lazy to always include this myself ;)
Comment 14 Nate Graham 2018-02-14 18:36:06 UTC
What you describe would be really nice, but it's probably a question for the KDE sysadmins. Would you be able to start an email thread about that?
Comment 15 null 2018-02-14 18:38:28 UTC
I guess it'll come down to who is going to put in the work to implement this. What list would be best?
Comment 16 Nate Graham 2018-02-14 18:47:48 UTC
https://mail.kde.org/mailman/listinfo/sysadmin