Bug 164743 - Apply button not activated
Summary: Apply button not activated
Status: RESOLVED FIXED
Alias: None
Product: klipper
Classification: Unmaintained
Component: general (show other bugs)
Version: 0.9.6
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Esben Mose Hansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-23 12:52 UTC by Malte S. Stretz
Modified: 2009-02-02 14:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2008-06-23 12:52:21 UTC
Version:           v0.9.7 (using 4.00.83 (KDE 4.0.83 (KDE 4.1 Beta2), compiled sources)
Compiler:          gcc
OS:                Linux (i686) release 2.6.24-19-generic

Just a small glitch:  The Apply button in the Klipper config dialog is never activated.
Comment 1 Piotr Pełzowski 2008-07-18 22:28:11 UTC
I can confirm this bug also in KDE4.1RC1 (openSUSE packages). When you open Klipper configuration and for ex. uncheck "Separate clipboard and selections" and then check "Synchronise contents of the clipboard and selections" Apply button would by greyed out. 
Comment 2 FiNeX 2008-08-17 11:58:57 UTC
Confirmed even in current trunk.
Comment 3 Dmitry Suzdalev 2008-11-26 09:43:51 UTC
I fixed this bug in my klipper-kconfigxt branch.
The fix will be only in 4.3 though.
Comment 4 FiNeX 2008-11-26 11:09:24 UTC
can't you backport on kde 4.2?
Comment 5 Dmitry Suzdalev 2008-11-26 11:18:40 UTC
I guess no. Branch was created to port whole klipper to use kconfigxt and this fix is essential part of this port.

It can be backported only if release team agrees to see this porting effort as a non-new-feature. It's theoretiaclly possible to call this non-feature from user POV - no changes were made to user visible gui parts. But e.g. config file format slightly changed (in a way it'll still respect old user settings).

Also it can potentially introduce some new bugs - changes were not trivial.
While I must admit I have everything working and didn't notice some regressions so far...
Comment 6 FiNeX 2008-11-26 13:30:47 UTC
If no feature and no strings have been added, it is only a "backend" improvement, so it shouldn't be considered as a new feature, anyway I'm not the person who can decide it.

Is it possible to test it? Do you have a public repository? 
Comment 7 Dmitry Suzdalev 2008-11-26 13:34:34 UTC
Yep. It's here http://websvn.kde.org/branches/work/klipper-kconfigxt/

You'll need to cd to kdebase/workspace/klipper and do svn switch to this branch
Comment 8 Dmitry Suzdalev 2009-02-02 14:19:46 UTC
So this branch got merged to trunk => bug's fixed