Bug 164680 - restore triple click option to select from current word forward
Summary: restore triple click option to select from current word forward
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
: 214835 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-22 19:15 UTC by Fred Wells
Modified: 2009-12-06 06:36 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
configurable triple click mode (4.69 KB, patch)
2009-05-16 22:56 UTC, Rasto Stanik
Details
screenshot of Advanced tab with the added option (61.71 KB, image/png)
2009-07-27 20:11 UTC, Rasto Stanik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fred Wells 2008-06-22 19:16:00 UTC
Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

KDE Version: 4.1 beta 2 (4.00.83) 
Konsole Version: 2.1

The tripple click option to select "... only from the current forward" no longer exists in the new 4.1 version of Konsole.

Please, please, please restore this incredibly useful and time saving feature. :)
Comment 1 Matthew Woehlke 2008-08-14 20:00:51 UTC
Ah... no? KDE standard (and indeed used most other places) is that TC should select entire lines. Anyway, double-click already selects words (also standard to KDE and most places), so unless I miss something I don't understand how DC+drag is not what you want.

I'm not the maintainer, and Robert is free to make his own decisions, but IMO this should be WONTFIX.
Comment 2 Kurt Hindenburg 2008-08-15 05:30:07 UTC
Relax, KDE 3.5 had this option.  The reporter is just asking for it to be put back in KDE 4.  I'm not saying it should; I just updated the title to reflect what the reporter was asking for.
Comment 3 Fred Wells 2008-08-15 06:00:31 UTC
Consider that a very common use of any terminal emulator (unlike a word processor or Internet browser, for example) is to cut-n-paste portions of command lines for command repetition, duplication, documentation, etc.  DC+drag simply doesn't facilitate this use nearly as well and actually tends to slow the (power) user down.  The TC feature I'm requesting (among others) is not featured by any of the competition and IMO DISTINGUISHES KONSOLE FAVORABLY FROM THE CROWD.  This has been an anchor feature for me just as I suspect it has been for many others.   

Let's not let the power-users' needs be dismissed in the drive towards standards compliance and desktop dominance.  :)
Comment 4 Matthew Woehlke 2008-08-15 17:44:42 UTC
I still think it's an option to make the selection behavior wrong :-).

Ok, I guess you've convinced me it's useful, though. Hmm... right now, ctrl/shift have no effect on DC selection that I can see. What about making DC+modifier (either ctrl or shift) have this behavior unconditionally? Good idea? Bad idea?

If not, I guess I could live with an option (but not on by default, please).
Comment 5 Fred Wells 2008-08-16 18:51:16 UTC
I completely agree that it shouldn't be the default.  Let's make it configurable - just as it was in previous versions.  Adding a modifier like ctrl/shift could be an acceptable compromise.  Although I personally would prefer no modifier.  
Comment 6 Jacob Brown 2008-10-28 04:11:04 UTC
just starting using kde 4.1 (evaluating kubuntu 8.10), and so far this is the only issue I see holding me back from deploying it on my production workstations.
Comment 7 Mike Frysinger 2008-11-27 21:27:18 UTC
indeed ... a configure option (defaulting to off) is pretty standard behavior in the emulator world
Comment 8 J. Becker 2009-02-16 17:53:08 UTC
Agreed. This is a regression from previous versions. In KDE 2x and 3x, there was a checkbox available in a settings control panel, something like "Triple click from cursor position forward." Perhaps the "Input" or "Advanced" tabs of Konsole settings would be the right place. This is a very useful option to me, as well, as I often only need the last part of a line, skipping the shell prompt and any other areas.

Even without a checkbox of some sort, making it an option in the user's config file would be helpful.

This behavior looks like a clone of behavior originally in xterm and appears to have been added around 2002, which is probably around when I noticed it. It may be an obscure feature, but once you start using it, you'll badly miss it. It's one of my biggest gripes with terminal emulators found on that other operating system (aside from excellent support for color themes and really great tab support, which Konsole also provides with gusto.)

http://markmail.org/message/cx6tf5zjlkmvyqha
Comment 9 J. Becker 2009-02-16 20:25:16 UTC
test
Comment 10 Rasto Stanik 2009-05-16 21:20:08 UTC
The code for this is present in Konsole used in KDE 4.2.3. What is missing is a GUI for turning this feature on/off using TerminalDisplay::setTripleClickMode(TerminalDisplay::SelectForwardsFromCursor). The default value is set in ViewManager::createTerminalDisplay().
Comment 11 Rasto Stanik 2009-05-16 22:56:02 UTC
Created attachment 33739 [details]
configurable triple click mode

The patch adds a GUI option - a checkbox - on the Advanced tab of Konsole profile. The default is "off". If changed to on, the triple click selects from current word forwards.
Comment 12 Fred Wells 2009-05-20 05:10:30 UTC
Any chance getting this into 4.2.4, 4.3 or 4.3.1?
Comment 13 Rasto Stanik 2009-05-21 08:20:37 UTC
(In reply to comment #12)
> Any chance getting this into 4.2.4, 4.3 or 4.3.1?

Because there was no reaction (from konsole developers) here, I added the patch also to the reviewboard as recommended by the Patches Howto ( http://reviewboard.kde.org/r/722/ ). There is no reaction yet, but I guess we should give it a few more days. If nothing happens there is still a chance (a last one) to send it to a mailing list.

(To tell the truth, I'm a bit disappointed that it is so complicated and lengthy process to get a patch through. Especially if it is so simple as this one.)
Comment 14 Kurt Hindenburg 2009-05-21 18:32:27 UTC
4.3 is in string freeze, so this would have to wait for 4.4

I might suggest adding a dbus method to enable/disable this feature.  Then those people who want it can turn it on.
Comment 15 Rasto Stanik 2009-07-27 20:11:37 UTC
Created attachment 35678 [details]
screenshot of Advanced tab with the added option

A comment was added on reviewboard with comment "There is an issue as to whether we want this option in the Advanced tab as it is getting full."

I'm attaching a screenshot showing how it looks with my patch. Anybody has a suggestion for better wording or place where to put this option?
Comment 16 Mike Frysinger 2009-07-27 20:23:42 UTC
looks good to me, thanks
Comment 17 Jacob Brown 2009-07-27 20:29:31 UTC
It looks good to me. I can't wait to try it out! :)
Comment 18 J. Becker 2009-07-27 20:52:57 UTC
Excellent, can't wait to try it out either! :-)

Jacob Brown wrote:
> https://bugs.kde.org/show_bug.cgi?id=164680
>
>
>
>
>
> --- Comment #17 from Jacob Brown <jacob gnu org>  2009-07-27 20:29:31 ---
> It looks good to me. I can't wait to try it out! :)
>
>
Comment 19 Fred Wells 2009-07-28 04:13:08 UTC
Advanced tab seems the perfect place for this.  Looks good.  I also can't wait.
Comment 20 Kurt Hindenburg 2009-08-02 20:36:55 UTC
SVN commit 1005970 by hindenburg:

Allow option for triple-click to select from current word to end of line.

FEATURE: 164680


 M  +6 -0      EditProfileDialog.cpp  
 M  +1 -0      EditProfileDialog.h  
 M  +10 -0     EditProfileDialog.ui  
 M  +1 -0      Profile.cpp  
 M  +4 -0      Profile.h  
 M  +3 -0      ViewManager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1005970
Comment 21 Kurt Hindenburg 2009-12-06 06:36:31 UTC
*** Bug 214835 has been marked as a duplicate of this bug. ***