Bug 164489 - The terminal in Dolphin should stop emitting "cd xxx" commands once an application is running in the terminal
Summary: The terminal in Dolphin should stop emitting "cd xxx" commands once an applic...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (other bugs)
Version First Reported In: 16.12.2
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-20 01:57 UTC by Andreas Hoenselaar
Modified: 2020-12-20 14:13 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Hoenselaar 2008-06-20 01:57:29 UTC
Version:            (using Devel)
Installed from:    Compiled sources

In order to synchronize the current directory in the terminal with the one in Dolphin, 'cd xxx' commands are emitted in the terminal.
But when an application is running inside the terminal, eg vi, this is very annoying.
If possible, the 'cd' commands should stop if a child process is running inside the terminal.
Comment 1 FiNeX 2008-06-20 12:36:41 UTC
I agree with Andreas.
Comment 2 Rahman Duran 2009-03-29 13:54:42 UTC
SVN commit 946382 by rduran:

BUG: 164489

Make Dolphin benefit from new TerminalInterfaceV2 functions.



 M  +12 -4     terminalpanel.cpp  
 M  +2 -2      terminalpanel.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=946382
Comment 3 Bastiaan Hovestreydt 2009-04-28 14:34:15 UTC
Also, when I type a command but do not hit enter and change directory in the GUI the "cd xxx\n" is emitted so a messed up command is executed. This is very bad if I type "rm -r " and decide to change directory before I finish typing the command.

Judging from looking at the code, Rahmans fix doesn't seem to change this behaviour, but I couldn't test it.

So could this bug be reopened or shall I file a new bug?
Comment 4 Robert Knight 2009-04-28 15:04:45 UTC
> Judging from looking at the code,
> Rahmans fix doesn't seem to change this behaviour, but I couldn't test it.

If I remember correctly, he ran into the anticipated problem that the terminal view doesn't know what it is displaying or what the user's input means and so we don't know that the user has typed a command and has not yet pressed enter.
Comment 5 Dario Andres 2009-09-06 16:21:17 UTC
Bug 161637 seems to be related to this.