Bug 164318 - Changing locationbar from "navigate" to "edit" via click should pre-select the text
Summary: Changing locationbar from "navigate" to "edit" via click should pre-select th...
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: bars: location (show other bugs)
Version: 16.12.2
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
: 236614 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-17 19:09 UTC by Christoph Wiesen
Modified: 2017-09-23 13:51 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch: pre-select text when entering edit mode via click (611 bytes, patch)
2017-09-23 13:50 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Wiesen 2008-06-17 19:09:51 UTC
Version:            (using KDE 4.0.80)
Installed from:    Ubuntu Packages

... at least I think so. Mostly when I click on the breadcrumb navigation widget to go to the line edit mode I do this because I want to go to a completely different directory, so it would be helpful if the location in the line edit would be pre-selected, so I can type another path like /etc right away.

When I do this now its rather awkward to select all the text. Either I click the navigationbar thrice or I click it,do Ctrl+A and then start typing.

When browsing for duplicates I noticed #157589 which is about the same thing, but only for the "F6" shortcut (which I just learned about btw :)) but not about changing to line edit with the mouse. Since it's basically the same thing think the fix should be applied to changing the navigationbar style with the mouse (clicking it or using the context menu) as well.
Comment 1 Shaun Reich 2009-02-15 22:18:01 UTC
I disagree, the location bar should not select all on change from breadcrumb mode to text edit mode, as there is a button already to the right to clear all of the text. I usually end up changing just a little bit of the directory, i.e. from /home/kde-devel/kde/src/kdebase to replacing 'src' with 'build' , etc.
Comment 2 Christoph Wiesen 2009-02-16 18:41:44 UTC
While I can see your use case I do not think that it would be affected severely by changing the current behaviour. In your case you need to use the mouse to move the cursor to the desired portion of the path anyway (no matter if the text is selected or not), so there is hardly any additional action required.
In my tests on Dolphin 1.1 (KDE 4.1.2) the way you can click on / select text does not change in any way with the text beeing pre-selected or not. From what I see there is actually no difference for your case at all.

I do not think that the existence of the Qt standard Clear-Button within any LineEdit box should be used as a reason not to have a more natural way of dealing with such common use cases.
Comment 3 Shaun Reich 2009-02-16 20:17:10 UTC
Your right, I was under the impression that when the text was fully selected, it would interpret any mouse click + mouse move events, as a drag event, but it does not. It interprets it as a new selection, which is good in my opinion. In which case I don't disagree with this, since it really doesn't effect the other side of the case, in my opinion. 

The widget is called a KUrlNavigator and is pulled in by apps other than Dolphin too, like the file dialog iirc.

I would like to see somebody else state their opinions on this also.
Comment 4 Sergio PR 2009-04-20 12:21:12 UTC
I agree with you, it's very annoying when you create a new tab and it preserves the last location, and you have to select all the text in order to change it to a new location T_T
Comment 5 Jekyll Wu 2012-01-06 20:06:06 UTC
*** Bug 236614 has been marked as a duplicate of this bug. ***
Comment 6 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:19:37 UTC
Resetting assignee to default as per bug #305719
Comment 7 Nate Graham 2017-09-22 21:23:33 UTC
I agree too. Here's a patch: https://phabricator.kde.org/D7944
Comment 8 Nate Graham 2017-09-23 13:50:39 UTC
Created attachment 107969 [details]
Patch: pre-select text when entering edit mode via click

After some discussion on Phabricator, I'm afraid this has to be a WONTFIX. Here are the reasons:

1. Many modern web browsers like Firefox actually *don't* pre-select the text when you click on the URL bar, and only do it when you hit ctrl-L. The URL navigator already behaves this way, so we would be reducing consistency with those web browsers, not increasing it.

2. The feature is already implemented via the "Replace Location" menu item with shortcut ctrl-L; if you want to completely replace the URL bar location, just use that, via the menu or keyboard shortcut, instead of clicking on the URL bar.

3. By entirely removing the option to edit without pre-selecting, this would impair use cases when you just want to edit a bit of the path and not completely replace it.

That said, for anyone who really really wants this feature, I'm attaching a patch to KIO that makes it behave this way.