Bug 163858 - please add cancel and OK buttons
Summary: please add cancel and OK buttons
Status: RESOLVED NOT A BUG
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: System Settings Bugs
URL:
Keywords:
: 163854 163855 163856 163857 163859 163860 163861 163862 163863 163864 163865 163866 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-12 08:14 UTC by Maciej Pilichowski
Modified: 2009-05-02 01:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2008-06-12 08:14:25 UTC
Version:            (using KDE 4.0.82)
Installed from:    Ubuntu Packages

There is an apply button, so user can explicitly apply changes. There should be a counterpart button to cancel changes.

Adding OK button would also very useful (because of the intuitive behaviour).
Comment 1 Andreas Pakulat 2008-06-12 08:56:24 UTC
I think this is by design and a cancel button is really inapropriate, especially in the place where Apply sits.

To exit systemsettings you can just close the window using the window-manager-titlebar. To cancel your changes just go back to the overview or hit "Reset".

A cancel bar at the same place where it is when you run execkde4 kcmshell4 kwindecoration, would be confusing: Does it cancel editing in this KControl module and go back to the overview, or does it cancel the whole dialog and thus exit systemsettings?

I'm not maintaining that application, hence I'm not changing the bugreport (except the wrong component setting), but I think this is a wontfix.
Comment 2 Maciej Pilichowski 2008-06-12 09:17:37 UTC
ad.1) quite contrary, see HIG

ad.2) the same argument could be used to _remove_ the apply --> just click on overview and click "save".
With cancel there is little mouse movement, less clicks, and both parts are present (accepting and rejecting changes)

ad.3) because of the design of SS, it would cancel current module
Comment 3 Matthew Woehlke 2008-06-12 20:28:21 UTC
To make this clear... there is arguably a problem with the buttons in kcms (Maciej says there is, apaku says there isn't... I'm declining from taking a stance). Please discuss it in this bug report.

I'm getting the impression a "revert applied changes" button might also be wanted? Not sure if that's true, though, or if we should have such a thing.
Comment 4 Matthew Woehlke 2008-06-12 20:28:37 UTC
*** Bug 163860 has been marked as a duplicate of this bug. ***
Comment 5 Matthew Woehlke 2008-06-12 20:28:46 UTC
*** Bug 163863 has been marked as a duplicate of this bug. ***
Comment 6 Matthew Woehlke 2008-06-12 20:28:53 UTC
*** Bug 163862 has been marked as a duplicate of this bug. ***
Comment 7 Matthew Woehlke 2008-06-12 20:29:02 UTC
*** Bug 163856 has been marked as a duplicate of this bug. ***
Comment 8 Matthew Woehlke 2008-06-12 20:29:08 UTC
*** Bug 163866 has been marked as a duplicate of this bug. ***
Comment 9 Matthew Woehlke 2008-06-12 20:29:15 UTC
*** Bug 163861 has been marked as a duplicate of this bug. ***
Comment 10 Matthew Woehlke 2008-06-12 20:29:24 UTC
*** Bug 163857 has been marked as a duplicate of this bug. ***
Comment 11 Matthew Woehlke 2008-06-12 20:29:33 UTC
*** Bug 163864 has been marked as a duplicate of this bug. ***
Comment 12 Matthew Woehlke 2008-06-12 20:29:46 UTC
*** Bug 163854 has been marked as a duplicate of this bug. ***
Comment 13 Matthew Woehlke 2008-06-12 20:29:53 UTC
*** Bug 163855 has been marked as a duplicate of this bug. ***
Comment 14 Matthew Woehlke 2008-06-12 20:30:03 UTC
*** Bug 163865 has been marked as a duplicate of this bug. ***
Comment 15 Matthew Woehlke 2008-06-12 20:30:22 UTC
*** Bug 163859 has been marked as a duplicate of this bug. ***
Comment 16 Maciej Pilichowski 2008-06-12 21:04:09 UTC
Once again, sorry for all those reports, I thought I did it ok.

About undo -- yes, indeed. Useful companion to "defaults".
Comment 17 Ben Cooksley 2009-05-02 01:27:52 UTC
This does not make sense from a usability point of view, since "Ok" and "Cancel" both imply that the module is being closed when it is not, and who already exist in the form of apply and reset.