Bug 163391 - "enlarge/shrink font" actions no longer available (regression from 3.5)
Summary: "enlarge/shrink font" actions no longer available (regression from 3.5)
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 168195 193161 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-06 20:02 UTC by Hanno
Modified: 2009-07-26 22:20 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix zoom (5.50 KB, patch)
2009-07-08 22:58 UTC, Alexander Elbs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno 2008-06-06 20:02:15 UTC
Version:           1.2.50 (using 4.00.81 (KDE 4.0.81 >= 20080527) "release 6.3", compiled sources)
Compiler:          gcc
OS:                Linux (i686) release 2.6.22.17-0.1-default

In the "old" KDE3.5 Akregator version, one could increase the font size by 'Strg' + '+' ('Ctrl' + '+') and decrease it as well with '-'. This is a useful feature and the shortcut is consistent across programs (e.g. firefox, konqueror, okular, Adobe products ...). It would be nice if it was implemented in the new KDE4.1 version.
Comment 1 Christophe Marin 2008-06-06 21:01:17 UTC
CTRL + mouse wheel up/down is a good alternative (and it's already implemented).

Comment 2 Hanno 2008-06-06 21:41:14 UTC
true that works, although a second shortcut (which is widely used) would do no harm. It should also be added to the view menu, as users need to find the shortcut or should be able to zoom only with the mouse.
I won't need it anymore, but new users would expect it. Thanks for your advice :-)
Comment 3 Elez J. Shenhar 2008-08-05 14:26:47 UTC
I see that CTRL + mouse wheel doesn't change only the font size, it zooms the entire page so it doesn't fit in the window anymore.
There should probably be a way to increase just the font size, as with the KDE 3.x akregator.
The current situation must be problematic for people with vision impairments.
Comment 4 Hanno 2008-08-05 21:01:23 UTC
it also makes everything look kinda ugly and messes with smooth scrolling
Comment 5 Jonathan Marten 2009-06-26 18:18:17 UTC
*** Bug 168195 has been marked as a duplicate of this bug. ***
Comment 6 Alexander Elbs 2009-07-08 22:58:21 UTC
Created attachment 35169 [details]
Fix zoom

This patch enables ctrl-+ and ctrl-- again to enlarge/shrink the font of the articleviewer (font != zoom). These two actions are also added to the "View" menu.
Additionally actions for print (ctrl-p) and copy (ctrl-c) now also work again with shortcuts and are configurable in the shortcut configuration menu.

Does someone with svn account like to review and commit that patch? :)
Comment 7 Jonathan Marten 2009-07-09 18:04:21 UTC
Many thanks for your work on this Alexander;  for KDEPIM patches you should submit them to the review board (reviewboard.kde.org).  If approved, and you don't have an SVN account, then someone will be able to commit the patch for you.
Comment 8 Frank Osterfeld 2009-07-14 16:08:20 UTC
SVN commit 996539 by osterfeld:

This patch enables ctrl-+ and ctrl-- again to enlarge/shrink the font of the
articleviewer (font != zoom). These two actions are also added to the "View"
menu.
Additionally actions for print (ctrl-p) and copy (ctrl-c) now also work again
with shortcuts and are configurable in the shortcut configuration menu.

Patch by Alexander Elbs

BUG: 163391



 M  +21 -0     actionmanagerimpl.cpp  
 M  +3 -0      akregator_part.rc  
 M  +15 -28    articleviewer.cpp  
 M  +2 -2      articleviewer.rc  
 M  +2 -2      pageviewer.cpp  
 M  +2 -2      pageviewer.rc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=996539
Comment 9 Frank Osterfeld 2009-07-26 22:20:39 UTC
*** Bug 193161 has been marked as a duplicate of this bug. ***