Bug 162685 - Map key (legend) of OSM map theme is incomplete
Summary: Map key (legend) of OSM map theme is incomplete
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: data (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR task
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2008-05-27 02:43 UTC by Fabio Locati
Modified: 2012-12-06 20:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Locati 2008-05-27 02:43:26 UTC
Version:           svn (using Devel)
Installed from:    Compiled sources

I have noticed that only a little part of the objects in the OSM's map are in the legend. The complete list can be found here (http://wiki.openstreetmap.org/index.php/Map_Features). I think is better put all the things.
Comment 1 Torsten Rahn 2008-05-28 09:43:18 UTC
Hi Fabio,

Thanks for this very valuable information! This is actually something I had looked for before and hadn't found unfortunately.

Now there are two problems:
- The information on the page http://wiki.openstreetmap.org/index.php/Map_Features provides quite a huge amount of elements. Putting all those elements into the legend would make it quite large. So I fear that we need to make a selection and have a reference referring to the Url you have provided.
- We are in string freeze already for KDE 4.1. So if we want to change something for KDE 4.1 we have to keep the number of strings changed low (or better: change nothing for KDE 4.1 and postpone this bug to be fixed for KDE 4.2).

There are a few symbols that are sorely missing from the current legend (which I've compiled by looking at the map key provided on http://www.openstreetmap.org). I'll have a look whether we can pick a few more strings and add some basic things.

Fabio: you can easily create your own suggestion for a legend by modifying the file

/usr/local/share/apps/marble/data/maps/earth/openstreetmap/openstreetmap.dgml

That file contains a section called "legend" and sections in there which have items. Using a simple text editor you can modify those entries and save the dgml file to 

~/.marble/data/maps/earth/openstreetmap

Marble should then use your new dgml file. If you've created it up to your liking please attach it to this bug report or send it to marble-devel@kde.org

I'd appreciate any further input on this matter from you. You are also very much invited to visit us on IRC if you feel like it (#kde-edu on irc.freenode.org).
Comment 2 Torsten Rahn 2008-05-28 09:46:45 UTC
Remark: instead of 

/usr/local/share/apps/marble/data/maps/earth/openstreetmap/openstreetmap.dgml 
 
the dgml file could also get stored in

/usr/share/apps/marble/data/maps/earth/openstreetmap/openstreetmap.dgml 

or whereever Marble gets installed (you can find out by starting Marble from the konsole and looking for the "Marble Data Path (Compile Time)" line which looks like this for me: 

Marble Data Path (Compile Time): "/usr/local/share/apps/marble/data"

Best Wishes,

Torsten
Comment 3 Dennis Nienhüser 2012-11-19 21:40:50 UTC
To add the most common features to the legend:
- Find common tags in http://taginfo.openstreetmap.org/tags
- Filter those that are not visible in the map (cf. http://wiki.openstreetmap.org/wiki/Map_Features)
- Match to the correct icons (from http://www.sjjb.co.uk/mapicons/contactsheet)
- Add to the legend
Comment 4 Dennis Nienhüser 2012-12-06 20:49:27 UTC
Fixed in the kitchen branch.