Bug 161840 - playlist items from Mp3Tunes show up with no name and cryptic url after startup
Summary: playlist items from Mp3Tunes show up with no name and cryptic url after startup
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
Depends on:
Reported: 2008-05-09 11:54 UTC by Malte Doersam
Modified: 2008-08-15 17:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Malte Doersam 2008-05-09 11:54:17 UTC
Version:           neon 2008-05-08 (using Devel)
Installed from:    Compiled sources

If you add songs from mp3tunes and restart amarok these playlist items do not have a name only a url with cryptic numbers in it.

Amarok should either reload these items on startup or cache the name of the remote files, so they show up correctly...
Comment 1 Mark Kretschmann 2008-05-09 12:12:09 UTC
Yep, that's already known, thanks.
Comment 2 Casey Link 2008-08-13 11:03:00 UTC
This only happens on startup, because when amarok is looking for the collection the track belongs to the mp3tunes service hasn't been started yet.
Comment 3 Casey Link 2008-08-15 17:00:24 UTC
SVN commit 847525 by link:

This colossal commit enables async trackForUrl support for mp3tunes, however to achieve this MetaProxy was hacked to allow for selective updating of the proxied track. Due to the inheritance hierarchy in the design a chicken and egg problem developed where MetaProxy::name() would call itself causing infinite recursion. The solution was to add a "forwardToProxy" flag to MetaBase that by default does nothing, but is implemented in MetaProxy and ServiceMetaBase to allow for selective getting of cached or real metadata.

CCMAIL: maximilian.kossick@g­ooglemail.com
CCMAIL: amarok-devel@kde.org
BUG: 161840

 M  +30 -2     browsers/servicebrowser/ServiceMetaBase.cpp  
 M  +6 -0      browsers/servicebrowser/ServiceMetaBase.h  
 M  +2 -2      browsers/servicebrowser/mp3tunes/Mp3tunesServiceCollection.cpp  
 M  +9 -0      meta/Meta.h  
 M  +65 -33    meta/proxy/MetaProxy.cpp  
 M  +6 -1      meta/proxy/MetaProxy.h  
 M  +19 -2     meta/proxy/MetaProxy_p.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=847525