Bug 161594 - konqueror allows to cut files in read only directories
Summary: konqueror allows to cut files in read only directories
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
: 120574 (view as bug list)
Depends on:
Reported: 2008-05-04 11:57 UTC by Cyrill Helg
Modified: 2008-06-05 15:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Cyrill Helg 2008-05-04 11:57:00 UTC
Version:           svn (using Devel)
Installed from:    Compiled sources
Compiler:          Target: i686-pc-linux-gnu
OS:                Linux (i686) release 2.6.24-zen5-IBM-T43

Why does konqueror and dolhpin allow to cut files in read only directories? The menu entries for delete are disabled but not for cutting a file. 

That makes not much sense and should be disabled as well.
Comment 1 George Goldberg 2008-06-01 16:34:31 UTC
Confirmed with svn trunk r813544.
Comment 2 George Goldberg 2008-06-01 17:17:00 UTC
SVN commit 815362 by gberg:

Fix dolphin to only enable the Cut context menu option if the file capabilites supportsMoving().

CCBUGS: 161594

Still need to fix Send to trash Context Option in Konqueror

 M  +1 -0      dolphinmainwindow.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=815362
Comment 3 George Goldberg 2008-06-02 04:51:05 UTC
SVN commit 815517 by gberg:

Fix dolphinpart context menu so that the delete/rename/send to trash options are disabled when the directory containing the selected files/dirs is not writable.

CCBUGS: 161594

Issues remaining: Send to trash should be disabled on remote files (and replaced with delete) and edit menu of konqueror still has the actions like cut/delete/rename always enabled.

 M  +19 -9     dolphinpart.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=815517
Comment 4 George Goldberg 2008-06-02 04:57:50 UTC
SVN commit 815519 by gberg:

dolphin part context menu now displays delete and not send to trash for remote files. (Makes behaviour same is in dolphin itself).

CCBUGS: 161594

 M  +1 -1      dolphinpart.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=815519
Comment 5 George Goldberg 2008-06-02 12:07:44 UTC
SVN commit 815584 by gberg:

Fix the edit-menu action disabling/enabling bug in dolphinpart finally! Also, move FileItemCapabilities from dolphin to KonqFileItemCapabilities at dfaure's request (making it implicitly shared along the way).


 M  +1 -2      dolphin/src/CMakeLists.txt  
 M  +3 -3      dolphin/src/dolphincontextmenu.cpp  
 M  +3 -3      dolphin/src/dolphincontextmenu.h  
 M  +2 -2      dolphin/src/dolphinmainwindow.cpp  
 M  +26 -12    dolphin/src/dolphinpart.cpp  
 D             dolphin/src/fileitemcapabilities.cpp  
 D             dolphin/src/fileitemcapabilities.h  
 M  +2 -0      lib/konq/CMakeLists.txt  
 A             lib/konq/konq_fileitemcapabilities.cpp   dolphin/src/fileitemcapabilities.cpp#815516 [License: GPL (v2+)]
 A             lib/konq/konq_fileitemcapabilities.h   dolphin/src/fileitemcapabilities.h#815516 [License: GPL (v2+)]

WebSVN link: http://websvn.kde.org/?view=rev&revision=815584
Comment 6 Jaime Torres 2008-06-05 15:58:50 UTC
*** Bug 120574 has been marked as a duplicate of this bug. ***