Bug 161084 - not properly updates status bar info
Summary: not properly updates status bar info
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-MainView (show other bugs)
Version: 0.9.4
Platform: Compiled Sources Linux
: HI normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-20 21:40 UTC by Mikolaj Machowski
Modified: 2012-08-09 07:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikolaj Machowski 2008-04-20 21:40:35 UTC
Version:           0.9.4-svn (using Devel)
Installed from:    Compiled sources
Compiler:          gcc4.3 
OS:                Linux

After filtering on status line (as with rating) image description isn't
updated automatically. Example: 

Focus is on image.jpg . This is 6th image of 120. Status line is:

image.jpg (6 of 120)

Set rating of this image to five stars. Start filtering, Even when
filtering left only this one image text in status line is the same. Only
change of focus brings change.
Comment 1 Mikolaj Machowski 2008-04-20 21:45:17 UTC
According to Gilles' wish on mailing list upping priority.
Comment 2 Marcel Wiesweg 2008-04-22 15:01:37 UTC
This would be a working, quick fix:
Index: digikam/iconview.cpp
===================================================================
--- digikam/iconview.cpp        (Revision 799809)
+++ digikam/iconview.cpp        (Arbeitskopie)
@@ -517,7 +517,8 @@

     // Remove from selected item list
     d->selectedItems.remove(item);
-    if (item->isSelected())
+    // See bug 161084
+    if (d->selectedItems.count() || item->isSelected())
         d->needEmitSelectionChanged = true;

     if (d->toolTipItem == item)

but there has not been any change in that area lately, so if as Gilles said this bug was introduced since beta1, the reason must be elsewhere. Currently I dont know how this could have worked. The status line is updated on signalSelectionChanged, and when one item is selected and remains selected, although all other items are removed, the selection does not changed. The patch above causes emitting the signal always if there is a selection and any item is removed (so it's then signalSelectionChangedOrTotalNumberOfItemsChanged() actually ;-) )
Comment 3 caulier.gilles 2008-04-22 15:53:30 UTC
Marcel,

Sound like you patch fix the problem. But i'm not sure than it solve the real problem... (:=)))

Are you tried to reproduce the 2nd problem discuted on irc : 

- 1/ Open right sidebar in metadata or properties tab.
- 2/ Select an album with items.
- 3/ Close digikam
- 4/ Restart it.
- 5/ Sometimes, the right sidebar is not updated with the first item selected from last open album, just after startup.

Notes : 

- This is not reproductible each time.
- I have not yet tested on my laptop with your patch to see if this problem is fixed too.

Mik, can you confirm if patch work for you ?

Gilles

Comment 4 Mikolaj Machowski 2008-04-22 20:22:03 UTC
> Mik, can you confirm if patch work for you ?


Fixes partially. Status info changes when before filtering action focus
wasn't on one of images which will stay visible after filtering. In
other words - when focus change will be enforced by reduced number of
visible items. If focus is on one of images which would be visible after
filter action - status bar text is not changed.
Comment 5 caulier.gilles 2008-04-25 12:16:59 UTC
Mik,

It's not clear for me. Can you give me a action list to do to reproduce it ?

Thanks in advance

Gilles
Comment 6 caulier.gilles 2008-04-25 12:18:35 UTC
SVN commit 800961 by cgilles:

patch fromMarcel to force updating of status bar with selection
CCBUGS: 161084


 M  +2 -1      iconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=800961
Comment 7 caulier.gilles 2008-04-25 12:20:47 UTC
SVN commit 800964 by cgilles:

backport commit #800961 from KDE3 branch
CCBUGS: 161084


 M  +2 -1      iconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=800964
Comment 8 Mikolaj Machowski 2008-04-26 08:25:42 UTC
After clean compilation works for me. One side effect: after assignment of rating status bar info is cleared.

May I close this bug report or something else is to be done?
Comment 9 caulier.gilles 2008-04-26 08:40:53 UTC
Mik,

Agree. I have already seen a dysfunction between Rating filter and Filter spot light. I suspect something wrong in AlbumLister class. This is another problem.

Gilles
Comment 10 caulier.gilles 2008-04-26 09:42:56 UTC
Mik,

I close this file. Please open a new one about comment #8. Thanks in advance

Gilles