Bug 158552 - In fullscreen view, video is resized when toolbar appears
Summary: In fullscreen view, video is resized when toolbar appears
Status: CONFIRMED
Alias: None
Product: dragonplayer
Classification: Applications
Component: general (show other bugs)
Version: 22.11.90
Platform: Slackware Linux
: NOR minor
Target Milestone: ---
Assignee: Dragon Player Mailing List
URL:
Keywords:
: 158553 306636 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-28 22:46 UTC by Dave Taylor
Modified: 2022-11-26 05:11 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Taylor 2008-02-28 22:46:53 UTC
Version:           2.0 (using KDE 4.0.1)
Installed from:    Ubuntu Packages
OS:                Linux

When Dragon-Player is in full screen mode and one moves their mouse a control panel magically appears at the top but ever time said panel appears the video playing resizes. I originally brought this to Max's attention and had it corrected in Codeine but it has since found its way back in to Dragon-Player.

The volume slider has the same undesired effect in both fullscreen and in a window.
Comment 1 Fabio Locati 2008-03-11 18:17:24 UTC
unspe -> svn
Comment 2 Fabio Locati 2008-03-11 18:18:11 UTC
unspecific -> svn
Comment 3 David Dempster 2008-06-22 08:36:55 UTC
I have "Dragon Player / Version 2.0 / Using KDE 4.00.80 (KDE 4.0.80 >= (KDE 4.1 Beta1)".

I can confirm that this bug exists and is very annoying.  It reminds of the early days of RealPlayer.
Comment 4 Dave Taylor 2008-11-07 22:03:10 UTC
Problem still exists in version 2.0 - come on chaps Max had this nailed in Codeine within a week not nine months unless this is due to Phonon in some way?
Comment 5 David Edmundson 2008-11-08 00:22:16 UTC
Very much phonon. Ideally we could just say "draw a video widget. Then draw this on top" but we can't. The phonon-xine code works out where the widget is in screen co-ordinates then tells xine to draw over the screen with the video. Anything we draw there would just get drawn over immediately without QT knowing about it. The first feasible solution is simply to resize the video widget. Also any fix needs all the engines to support it. Which is more work.

The other reason is that there aren't many people working on Dragon Player. It's mostly just Ian and I. Ian's busy with Amarok and switching jobs, and I'm struggling to find time too.

Feel free to help.
Comment 6 Fabio Locati 2008-11-25 22:21:20 UTC
move to phonon
Comment 7 Matthias Kretz 2008-11-29 12:52:09 UTC
There's two parts to this bug I guess:
1. dragon resizes the VideoWidget which it shouldn't. It should just draw the toolbar on top of it.

2. video rendering is done in an extra X window (using XV), if that window is partially covered the video drawing should not affect the covering widgets. I've seen no example of this happening yet, so if you could point me to such an issue I can look into the problem.

If VideoWidget really draws over other widgets please try to make the covering widget an own X window (i.e. not using the Qt internal widget compositing, aka "Alien Widgets") as a workaround and reassign the bug report back to me telling how to reproduce the problem.
Comment 8 David Edmundson 2008-11-29 17:06:47 UTC
Mathias, thanks for looking into this. I was trying to do overlapping by settings the toolbar to be the child of the video widget. Which works for other widgets, but understandably not for the phonon video widget.

Before I head down the alien widget path, is there a more sensible solution to get various widgets to cover the video playing area?
Comment 9 David Edmundson 2008-11-29 17:09:31 UTC
Edit:
using 
setAttribute(Qt::WA_PaintOnScreen);

works flawlessly. Nice!
Comment 10 Georg Wittenburg 2009-01-04 22:44:39 UTC
(In reply to comment #9)
> works flawlessly. Nice!

I take it from this comment that a fix to this bug exists? If that's the case, what are the chances of fixing it in 4.2? As of 4.1.86 (using unofficial Debian packages from kde42.debian.net at version 4:4.1.86+svn901128-0r1) I'm still seeing this bug.
Comment 11 Fabio Locati 2009-01-04 23:07:04 UTC
David has completly rewritten the fullscreen mode, and he thinks that commit it in a frozen trunk would break it. Than he will expect until the defrozen of the trunk to commit it.
Comment 12 Georg Wittenburg 2009-01-04 23:10:10 UTC
Great! Thanks for your work on this! :)
Comment 13 Fabio Locati 2009-01-04 23:11:20 UTC
*** Bug 158553 has been marked as a duplicate of this bug. ***
Comment 14 Georg Wittenburg 2010-03-07 09:00:39 UTC
Still present in 4.4.1.
Comment 15 Harald Sitter 2012-09-11 21:06:24 UTC
*** Bug 306636 has been marked as a duplicate of this bug. ***
Comment 16 Neousr 2019-02-14 01:45:35 UTC
Retested on version 18.12.2. This continue to be true on full screen mode by moving the mouse the toolbar will show and then the video will resize. The same happens when the volume icon is pressed.

On window mode the same applies along the video control menu doing the same after being pressed from the settings menu.

From what i can see this reduce considerably the appeal of Dragon player on the usability standpoint from a normal user.

Seeing how much Gstreamer has been been getting better and a possible phonon backend on the works. This would let Dragon player shine along the rest of the KDE apps.