Bug 156381 - dolphin should open filter bar using '/' like find as type
Summary: dolphin should open filter bar using '/' like find as type
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: filter (show other bugs)
Version: 16.12.2
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2008-01-22 14:40 UTC by CSights
Modified: 2018-03-03 05:49 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.04.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description CSights 2008-01-22 14:40:53 UTC
Version:           1.0 (using 4.00.00 (KDE 4.0.0), Debian packages)
Compiler:          gcc
OS:                Linux (i686) release 2.6.23.9

Hi,
   Dolphin's filter bar is very much like "find as you type" in konqueror, which is activated by default using '/'.  It would make sense IMO to make the activation and behavior of filter bar more like "find as type".  I.e. the filter bar appears upon pushing '/' (instead of default ctrl-I), you type, non-matching files and directories disappear, and then when you click or do anything else the filter bar disappears.

Thanks and congratulations on KDE 4.0.0!
  C.
Comment 1 Peter Penz 2008-01-22 15:04:56 UTC
Thanks for your input, we originally wanted to take '/' but this shortcut clashes as soon as the terminal is opened :-( Do you have a suggestion how to solve this problem (I mean not technically, but more what should happen if someone presses '/' during the terminal is open)?

> Thanks and congratulations on KDE 4.0.0! 

Thanks for testing and giving feedback :-)
Comment 2 CSights 2008-01-22 20:38:20 UTC
I'm not sure what you mean by "terminal".  I tried opening konsole and then typing '/' with dolphin in the foreground and konsole in background.  I didn't notice anything happening.

Maybe the '/'-find-while-typing would only work if the focus is in the dolphin file listing pane.  So one would have to click in that pane or tab to it before using '/'.   (It would be better if the focus just needed to be on dolphin, but my guess is "terminal" is part of dolphin.)

Thanks again!
  C.
Comment 3 Peter Penz 2008-01-22 20:49:43 UTC
> I'm not sure what you mean by "terminal".

I meant selecting View -> Panels -> Terminal (F4), so that the embedded konsole is part of the Dolphin window. Now when '/' is the shortcut for the filter, it would not be possible typing any '/' inside the konsole/terminal ;-)

> Maybe the '/'-find-while-typing would only work if the focus is
> in the dolphin file listing pane.

Hmm, as typing is not possible anyway without the focus, this might be a solution. I'll play around with this a little bit, let's see... :-)
Comment 4 disclosed 2008-06-03 22:47:26 UTC
Actually it would be even better if "find as you type" worked like in konqueror 3.5.x.

From whatever position in the file listing, if you type a letter find the next directory or file that matches.


many keystrokes within a short time should result in longer search term. (just like in old konqueror)

 
Comment 5 Nicolas Brisset 2009-01-16 18:07:28 UTC
I also think that this would be a nice feature, and I don't see a problem with the embedded console as this should work only when the file list pane has the focus.
Comment 6 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:22:28 UTC
Resetting assignee to default as per bug #305719
Comment 7 Todd 2012-09-02 19:51:15 UTC
Is there a reason you can't manually change the shortcut?  Changing the shortcut by default now would probably be confusing for many people used to the current shortcut.
Comment 8 quamis 2012-10-31 18:24:27 UTC
(In reply to comment #4)
> Actually it would be even better if "find as you type" worked like in
> konqueror 3.5.x.
> 
> From whatever position in the file listing, if you type a letter find the
> next directory or file that matches.
> 
> 
> many keystrokes within a short time should result in longer search term.
> (just like in old konqueror)

It works now. Dolphion 2.0/KDE4.8.5. 
I'm not sure how it worked in the old Konqueror, but partially typing in the filename, will automatically select the file.
Comment 9 Jekyll Wu 2012-10-31 23:08:07 UTC
FYI,  if you use KDE SC 4.9.x (can't remember clearly about 4.8.x), "/" will always be intercepted by konsolepart (the embedded terminal) when it has the focus, instead of triggering a action. So Peter's concern in comment #1 is "solved".

(In reply to comment #5)
> I don't see a problem
> with the embedded console as this should work only when the file list pane
> has the focus.

It was a problem, because typing "/" in the embedded terminal would trigger the filter bar, which made the embedded terminal practically useless.

(In reply to comment #4)
> Actually it would be even better if "find as you type" worked like in
> konqueror 3.5.x.
> 
> From whatever position in the file listing, if you type a letter find the
> next directory or file that matches.
> 
> 
> many keystrokes within a short time should result in longer search term.
> (just like in old konqueror)

What filter bar does it "filtering". It is quite *different* from "find as you type" . And dolphin supports "find as you type" too (no shortcut is needed to activate that feature ),  just maybe not as friendly and noticeable as in other filemanagers (thunar, pcmanfm). Or, have I misunderstood what that "find as you type" feature mean in the old and new konqueror?
Comment 10 Roman Inflianskas 2018-03-03 05:39:19 UTC
Git commit bf0d259ae50d559bae9847051d3cf96b3d85076c by Roman Inflianskas.
Committed on 03/03/2018 at 05:38.
Pushed by romaninflianskas into branch 'master'.

Add default shortcut "/" for opening filter panel

Summary:
Add default shortcut "/" for opening filter panel.

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10961

M  +1    -1    src/dolphinmainwindow.cpp

https://commits.kde.org/dolphin/bf0d259ae50d559bae9847051d3cf96b3d85076c