Bug 155575 - More "empty space" in icon view
Summary: More "empty space" in icon view
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
Depends on:
Reported: 2008-01-12 21:41 UTC by Grósz Dániel
Modified: 2008-03-20 17:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Rectangle selection bug (238.96 KB, image/png)
2008-01-13 10:05 UTC, Ildar Nurislamov

Note You need to log in before you can comment on or make changes to this bug.
Description Grósz Dániel 2008-01-12 21:41:11 UTC
Version:            (using KDE KDE 4.0.0)
Installed from:    SuSE RPMs
OS:                Linux

To select several files with selection rectangle with mouse, one needs to first click on the empty place. However, in the icon view of Dolphin, empty space is very little, much less than in Konqueror 3 icon view, so it is very easy to accidentally click on the active area of an icon and open it. Clicking on places which look empty (outside of the icon and the label) should behave as empty places.
Comment 1 Peter Penz 2008-01-12 22:07:11 UTC
You can increase the empty space in the settings menu. Is this sufficient for you? Anyway we'll add an option in KDE 4.1 to make the selection boundaries configurable. If you want to have this kind of option, then I'll confirm this issue to "NEW", otherwise I would resolve the issue as "WORKSFORME". OK? :-)
Comment 2 Grósz Dániel 2008-01-12 22:44:00 UTC
Thank you for the advice. With increased grid size, it is indeed easier to click on the empty space, but there is needlessly much white space between icons (compared to Konqueror). So it is good to read for me that this will be configurable in 4.1.
Comment 3 Ildar Nurislamov 2008-01-13 10:05:25 UTC
Created attachment 22985 [details]
Rectangle selection bug

file begin selected before rectangle selection touch its bounding box
Comment 4 Ildar Nurislamov 2008-01-13 10:12:01 UTC
There is a bug in detection of boundaries of file. I attach screenshot where you can see that real file boundaries much bigger that drawed boundaries. In this situation clicking on empty space causes opening of file. It looks like bigger boundries have files with long filenames. 

ildar100.jpg on screenshot have short filename and normal boundaries but IrfanView_Wallpaper.bmp have long filename and its boundaries captures empty space.
Comment 5 Ildar Nurislamov 2008-03-04 21:15:48 UTC
Please consider my report about Rectangle selection and bounding box  bug.
Comment 6 Peter Penz 2008-03-04 21:51:11 UTC
I did not forget about your bug-report, on trunk it's already resolved. But we still wait for a Qt-fix for 4.4 final regarding the word wrapping and I did not want to set this issue to resolved until we have a 100 % working solution.
Comment 7 Peter Penz 2008-03-20 17:59:28 UTC
SVN commit 788095 by ppenz:

QListView does not support having a margin for grids. Originally it has been tried to bypass this by overwriting QListView::visualRect(), but this has some side effects (see #155378 and #155575). The clean approach is to return a proper size hint in the file item delegate.

Currently a custom item delegate has been made for Dolphin, but we'll discuss whether it makes sense providing this feature already in KFileItemDelegate...

BUG: 155378
BUG: 155575
CCMAIL: fredrik@kde.org

 M  +1 -0      CMakeLists.txt  
 A             dolphinfileitemdelegate.cpp   [License: GPL (v2+)]
 A             dolphinfileitemdelegate.h   [License: GPL (v2+)]
 M  +6 -44     dolphiniconsview.cpp  
 M  +0 -3      dolphiniconsview.h  
 M  +2 -2      dolphinview.cpp  
 M  +2 -1      dolphinview.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=788095