Bug 155378 - Icons are messed up after creating a new folder
Summary: Icons are messed up after creating a new folder
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
Depends on:
Reported: 2008-01-10 08:08 UTC by András Manţia
Modified: 2008-03-20 17:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

How it looked before the new folder was created (138.60 KB, image/png)
2008-01-10 08:08 UTC, András Manţia
The bug, here I created the TEST folder (139.33 KB, image/png)
2008-01-10 08:10 UTC, András Manţia

Note You need to log in before you can comment on or make changes to this bug.
Description András Manţia 2008-01-10 08:08:17 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

If I have a folder with many entries and there I create a new folder, the icon layout is messed up completely. The strange is:
- it happened (always) in Konqueror using the dolphin part (see the screenshots)
- I couldn't reproduce in Dolphin
- after Dolphin was started I couldn't reproduce in Konqueror
Comment 1 András Manţia 2008-01-10 08:08:59 UTC
Created attachment 22927 [details]
How it looked before the new folder was created
Comment 2 András Manţia 2008-01-10 08:10:26 UTC
Created attachment 22928 [details]
The bug, here I created the TEST folder
Comment 3 Peter Penz 2008-01-10 16:45:28 UTC
Hi András! This is a known issue and seems to be inside Qt 4.3.x. But I'm not 100 % sure yet and need time reproducing this within a Qt-only application to prove it. At the moment Dolphin bypasses this issue by a workaround, but this workaround might fail too with very long filenames (without the workaround even more items would be aligned in a wrong manner). It's on my internal TODO list and this issue will be fixed, I just fear that I need some time for this and I'm not sure whether I can fix this until 4.0.1
Comment 4 Peter Penz 2008-03-20 08:43:20 UTC
Hi András, good news: I could fix this issue and will commit an update this evening :-)
Comment 5 Peter Penz 2008-03-20 17:59:28 UTC
SVN commit 788095 by ppenz:

QListView does not support having a margin for grids. Originally it has been tried to bypass this by overwriting QListView::visualRect(), but this has some side effects (see #155378 and #155575). The clean approach is to return a proper size hint in the file item delegate.

Currently a custom item delegate has been made for Dolphin, but we'll discuss whether it makes sense providing this feature already in KFileItemDelegate...

BUG: 155378
BUG: 155575
CCMAIL: fredrik@kde.org

 M  +1 -0      CMakeLists.txt  
 A             dolphinfileitemdelegate.cpp   [License: GPL (v2+)]
 A             dolphinfileitemdelegate.h   [License: GPL (v2+)]
 M  +6 -44     dolphiniconsview.cpp  
 M  +0 -3      dolphiniconsview.h  
 M  +2 -2      dolphinview.cpp  
 M  +2 -1      dolphinview.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=788095