Bug 154561 - [RFE] [PATCH] Hunspell support for legacy KSpell/K3Spell
Summary: [RFE] [PATCH] Hunspell support for legacy KSpell/K3Spell
Status: RESOLVED INTENTIONAL
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kspell (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Zack Rusin
URL:
Keywords:
: 121228 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-12-24 00:42 UTC by Kevin Kofler
Modified: 2008-08-30 16:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Hunspell support for legacy KSpell (9.54 KB, patch)
2007-12-24 00:44 UTC, Kevin Kofler
Details
Hunspell support for K3Spell in KDE 4 (10.17 KB, patch)
2008-01-19 17:15 UTC, Kevin Kofler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2007-12-24 00:42:31 UTC
Version:            (using KDE KDE 3.5.8)
Installed from:    Fedora RPMs

In Fedora, we are trying to reduce the proliferation of dictionaries and spellchecking tools. Therefore, we want to make as many applications as possible use the hunspell spellchecker, either directly or through the enchant abstraction layer. See http://fedoraproject.org/wiki/Releases/FeatureDictionary for details. This will also ensure KDE 3 and KDE 4 apps use the same spellchecking dictionaries (and incidentally also the same ones as other applications).

I implemented support for the Hunspell command-line spellchecker (which has an ispell-compatible pipe interface) in KSpell (the legacy "KSpell 1").

See also http://bugs.kde.org/show_bug.cgi?id=154560 for KSpell2.
Comment 1 Kevin Kofler 2007-12-24 00:44:56 UTC
Created attachment 22665 [details]
Hunspell support for legacy KSpell
Comment 2 Kevin Kofler 2008-01-19 17:15:03 UTC
Created attachment 23138 [details]
Hunspell support for K3Spell in KDE 4

I just noticed K3Spell is still used in some places in KDE 4 (e.g. the
KatePart). This is a forward-port of the KSpell Hunspell patch to the K3Spell
in KDE 4.
Comment 3 Kevin Kofler 2008-05-27 20:03:54 UTC
*** Bug 121228 has been marked as a duplicate of this bug. ***
Comment 4 Zack Rusin 2008-08-27 17:00:50 UTC
This is another very nice patch but it's the same situation as 154560.

And to quote me from the other report:
I'm closing with WONTFIX but because I don't have resources time to do KDE3 development, not because I think it's wrong and as mentioned you're of course free to commit it (assuming the release team will be ok with it) as long as you'll maintain it. 
Comment 5 Kevin Kofler 2008-08-28 00:42:24 UTC
What about the patch to K3Spell in KDE 4? Should that also be considered unmaintained?
Comment 6 Pino Toscano 2008-08-30 10:52:46 UTC
(In reply to comment #5)
> What about the patch to K3Spell in KDE 4? Should that also be considered
> unmaintained?

K3Spell is part of the kde3support module, that means "this is KDE 3 compatibility, port to any KDE 4 technology ASAP". The KDE4 technology is called Sonnet.
IMHO it makes very little sense adding a new feature that was not in KDE 3, for a class/system that developers are supposed to port away from.
Comment 7 Kevin Kofler 2008-08-30 16:08:36 UTC
Well, that's why I want to add it to KDE 3 too. ;-)

In Fedora 9, we're shipping those patches (also the KSpell2 one in KDE 3) and they work fine, and the nice thing for system integration is that they make sure all the apps use Hunspell as their dictionary (we're also setting the option in our kde-settings to make it the default).

What also worries me is that if those patches aren't included, different distributions will add different spelling engines (there are also others which could get support, for example tmispell-voikko for which I have a tentative patch) and the enumeration values will vary from distro to distro, making a big mess.
Comment 8 Kevin Kofler 2008-08-30 16:13:13 UTC
Oh, and I know apps shouldn't be using K3Spell anymore, but the fact is that they do and it's bad for integration if the apps still using K3Spell use aspell whereas the ones already ported to Sonnet use hunspell (because that's the default in Enchant, and that's normal because it's more powerful than aspell and probably what most distributions will standardize on, Fedora definitely did, see our FeatureDictionary page), they get completely different dictionaries. It also means you have to install 2 spellcheckers. In Fedora 9, we only require hunspell and that works thanks to those patches.