Bug 153761 - Cannot use autoreplace from "=)" without using regexp option
Summary: Cannot use autoreplace from "=)" without using regexp option
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-10 03:26 UTC by Daniel Hahler
Modified: 2009-04-17 23:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
workaround to allow special chars in non-regexp replace (1.60 KB, patch)
2009-04-06 20:04 UTC, Travis McHenry
Details
workaround to allow special chars in non-regexp replace (1.95 KB, patch)
2009-04-06 21:16 UTC, Travis McHenry
Details
changes autoreplace config format and fixes non-regex autoreplace (12.88 KB, patch)
2009-04-07 01:07 UTC, Travis McHenry
Details
new config format/non-regex autoreplace (14.27 KB, patch)
2009-04-08 05:42 UTC, Travis McHenry
Details
bugfix for last patch (14.33 KB, patch)
2009-04-10 04:16 UTC, Travis McHenry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Hahler 2007-12-10 03:26:46 UTC
Version:            (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages

I've setup a autoreplace from "=)" to "ツ" - but that did not work, until I've turned the option "regexp" on and used "=\)" instead.
Comment 1 Travis McHenry 2009-04-06 20:04:19 UTC
Created attachment 32658 [details]
workaround to allow special chars in non-regexp replace

This patch is just an ugly workaround for QRegExp being weird, it fixes the bug though.
Comment 2 Travis McHenry 2009-04-06 21:16:21 UTC
Created attachment 32662 [details]
workaround to allow special chars in non-regexp replace

Cleaner looking patch and supports all word boundrys (i think? o.O)
Also, it's more efficient than the old method even though it's more lines of code.
Comment 3 Travis McHenry 2009-04-07 01:07:48 UTC
Created attachment 32671 [details]
changes autoreplace config format and fixes non-regex autoreplace

this patch does the prior stuff and it changes the config format so commas don't mess up the reading of values. This also applys to bug https://bugs.kde.org/show_bug.cgi?id=139447
Comment 4 Travis McHenry 2009-04-08 05:42:22 UTC
Created attachment 32694 [details]
new config format/non-regex autoreplace

All the goodies of the previous with less bugs, more efficiency and better style.
Comment 5 Travis McHenry 2009-04-10 04:16:40 UTC
Created attachment 32736 [details]
bugfix for last patch

Fixes a small bug where the old code would fill the list backwards, and my new code would fill the list frontwards, so the autoreplaces would always reverse order when you saved it and reopened.
Comment 6 Eike Hein 2009-04-17 20:21:37 UTC
Patch committed in SVN revision 955466. Thanks!
Comment 7 Eike Hein 2009-04-17 20:25:08 UTC
SVN commit 955467 by hein:

Add a button to intelligently remove linebreaks from
multi-line pastes to the multi-line paste editor.
BUG:153761


 M  +37 -1     multilineedit.cpp  
 M  +1 -0      multilineedit.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=955467
Comment 8 Eike Hein 2009-04-17 20:50:15 UTC
That was the wrong 'BUG:number' there, sorry :). The commit belongs to bug 115668.
Comment 9 Daniel Hahler 2009-04-17 23:16:04 UTC
Thanks for clearing the loop in my brain.. ;)
Please re-open this bug then.
Comment 10 Daniel Hahler 2009-04-17 23:16:46 UTC
Oh, I can do this myself.
Comment 11 Eike Hein 2009-04-17 23:24:32 UTC
There's no need to reopen this bug. The bug is fixed as of SVN revision 955466 as written above in comment #6, I just mistakenly CC'd it with a commit (r955467) that is related to a different bug (via the 'BUG:' keyword in the commit message) afterwards.