Bug 149874 - Include dcraw version 8.77
Summary: Include dcraw version 8.77
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-DImg-RAW (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-14 23:00 UTC by Johannes Wienke
Modified: 2019-08-18 08:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Wienke 2007-09-14 23:00:06 UTC
Version:            (using KDE KDE 3.5.7)
Installed from:    Gentoo Packages

Please include dcraw 8.77 in the next version of digikam. It supports the new Olympus ORF images. At the moment previews for these images simply result in noise and long calculations for each image.
Comment 1 caulier.gilles 2007-09-14 23:09:20 UTC
Johannes,

Already done with future libkdcraw version 0.1.2. Not yet released but pre-tarball ready to test:

http://www.linux.it/~thewally/kipi/libkdcraw-0.1.2.tar.bz2

Valerio, it's when you want (:=)))...

Gilles Caulier
Comment 2 Johannes Wienke 2007-09-14 23:48:25 UTC
I just tried this. After linking libkdcraw.so.2 to libkdcraw.so.1 digikam starts correctly and thumbnail creation works perfectly, but opening an image results in a crash with this console log:

Found dcraw version: 8.77
Cannot load metadata using Exiv2  (/home/languitar/bilder/Bielefelder Nacht/P8032445.ORF: The file contains data of an unknown image type)
Running RAW decoding command: /usr/lib64/libkdcraw2/kdcraw -i -v '/home/languitar/bilder/Bielefelder Nacht/P8032445.ORF'
QDate::setYMD: Invalid date 2007-08-00
Exif color workspace tag set to: 65535
QFile::open: No file name specified
QFile::open: No file name specified
Cannot load metadata using Exiv2  (/home/languitar/bilder/Bielefelder Nacht/P8032445.ORF: The file contains data of an unknown image type)
Running RAW decoding command: /usr/lib64/libkdcraw2/kdcraw -i -v '/home/languitar/bilder/Bielefelder Nacht/P8032445.ORF'
QDate::setYMD: Invalid date 2007-08-00
Exif color workspace tag set to: 65535
Cannot load metadata using Exiv2  (/home/languitar/bilder/Bielefelder Nacht/P8032445.ORF: The file contains data of an unknown image type)
Running RAW decoding command: /usr/lib64/libkdcraw2/kdcraw -i -v '/home/languitar/bilder/Bielefelder Nacht/P8032445.ORF'
QDate::setYMD: Invalid date 2007-08-00
Exif color workspace tag set to: 65535
Running RAW decoding command: /usr/lib64/libkdcraw2/kdcraw -c -v -4 -w -a -H 0 -b 0 -q 0 -o 0 /home/languitar/bilder/Bielefelder Nacht/P8032445.ORF
RAW decoding StdErr: Loading OLYMPUS E-510 image from /home/languitar/bilder/Bielefelder Nacht/P8032445.ORF ...
KCrash: Application 'digikam' crashing...
KCrash cannot reach kdeinit, launching directly.
Comment 3 Gerhard Kulzer 2007-11-02 07:17:07 UTC
Well, as far as I can see libkdcraw version 0.1.2 is still not officially released and dcraw 8.78 with the inclusion of new important cameras is out.

Valerio, I have a patch ready to commit to svn that is based on 8.78. The dcraw API has changed in that 1 additional option is available now (-m), but the current libkdcraw use remains consistant. It is up to the applications to add the additional options.
Can I commit them?
Comment 4 Valerio Fuoglio 2007-11-02 07:55:10 UTC
Gerhard, I don't understand, libkdcraw 0.1.2 was released on September 17th.

If dcraw's API is changed and you patch libkdcraw, we'll need to change its dependencies (to exclude older versions).

Anyway, for commits, you'd better ask to Angelo ;)
Comment 5 caulier.gilles 2007-11-02 09:17:14 UTC
2 Nov 2007 06:17:10 -0000, Gerhard Kulzer <gerhard@kulzer.net>:
[bugs.kde.org quoted mail]


look here : http://www.kipi-plugins.org/drupal/node/4


Valerio, I have a patch ready to commit to svn that is based on 8.78. The
> dcraw API has changed in that 1 additional option is available now (-m), but
> the current libkdcraw use remains consistant. It is up to the applications
> to add the additional options.
> Can I commit them?



send me the patch. I will look what you have changed in code (outside
dcraw.c of course).

In general :

- For KDE3 branch, If dcraw command line interface is compatible, no need to
change the API/ABI version. the change still private. If it's possible, we
must preserve the binary compatibility. It's important for packagers.

- In KDE4, we can do what we want because nothing is already released and
API/ABI version is already incremented (for the future). If API change
because we use new dcraw options this is not a problem. There is no bnary
compatibility to preserve. KDE4 still under developement.

Gilles
2 Nov 2007 06:17:10 -0000, Gerhard Kulzer &lt;<a href="mailto:gerhard@kulzer.net">gerhard@kulzer.net</a>&gt;:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
------- You are receiving this mail because: -------<br>You are the assignee for the bug, or are watching the assignee.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=149874">http://bugs.kde.org/show_bug.cgi?id=149874
</a><br><br><br><br><br>------- Additional Comments From gerhard kulzer net&nbsp;&nbsp;2007-11-02 07:17 -------<br>Well, as far as I can see libkdcraw version 0.1.2 is still not officially released and dcraw 8.78 with the inclusion of new important cameras is out.
</blockquote><div><br>look here : <a href="http://www.kipi-plugins.org/drupal/node/4">http://www.kipi-plugins.org/drupal/node/4</a><br>&nbsp;</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Valerio, I have a patch ready to commit to svn that is based on 8.78. The dcraw API has changed in that 1 additional option is available now (-m), but the current libkdcraw use remains consistant. It is up to the applications to add the additional options.
<br>Can I commit them?</blockquote><div><br>send me the patch. I will look what you have changed in code (outside dcraw.c of course).<br><br>In general : <br><br>- For KDE3 branch, If dcraw command line interface is compatible, no need to change the API/ABI version. the change still private. If it&#39;s possible, we must preserve the binary compatibility. It&#39;s important for packagers.
<br><br>- In KDE4, we can do what we want because nothing is already released and API/ABI version is already incremented (for the future). If API change because we use new dcraw options this is not a problem. There is no bnary compatibility to preserve. KDE4 still under developement.
<br>&nbsp;</div></div>Gilles<br>
Comment 6 caulier.gilles 2019-08-18 08:52:52 UTC
Problem no longer exists in digiKam since we use libraw instead dcraw as well. dcraw source code is backported to libraw library at each release, and digiKam include last libraw stable code very quickly.

Gilles Caulier