Bug 149002 - [PATCH] Support for showing popfile headers in fancy headers
Summary: [PATCH] Support for showing popfile headers in fancy headers
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: kmail
Classification: Applications
Component: messageviewer (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-19 16:58 UTC by Sune Vuorela
Modified: 2012-08-19 00:26 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch to add popfile headers (1.69 KB, patch)
2007-08-19 16:59 UTC, Sune Vuorela
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sune Vuorela 2007-08-19 16:58:17 UTC
Version:            (using KDE KDE 3.5.7)
Installed from:    Debian testing/unstable Packages

Hi!

Popfile is a pop3 proxy that can put your emails in different categories (buckets). One use is to have two buckets, ham&spam and then it is a spam filter. Another use is distinguish between private or work email and ...
Occasionally, popfile is wrong and the mail needs to be reclassified with a http link in one of the headers.
I would like to have it possible to see the classification header and the header with the link to reclassification with fancy headers.

I have created a small patch that shows the headers as:
Popfile: bucketname  (Reclassify)  
with bucketname as the name of the popfile bucket the mail has ended up in - and having "reclassify" as a link to the http url.

The popfile: Header is only shown if people have checked the "show spam status" header in the configuration and the popfile headers are present and non-empty.

As popfile is a private pop3 proxy, it is not some headers that people in general have, so I think using the existing "show spam status" configuration is acceptable.
Comment 1 Sune Vuorela 2007-08-19 16:59:28 UTC
Created attachment 21432 [details]
patch to add popfile headers

Suggested patch.
Comment 2 Thomas McGuire 2007-08-22 13:10:48 UTC
Ok, some things about the patch:

1.
Adding features to the 3.5 branch is no longer allowed, please port your patch to KDE 4.

2.

If someone who uses popfile responses to someone who does not use it, the receiver still has the popfile headers in the mail, right? If the receiver uses KMail, he sees the popfile headers even though he does not use popfile himself, therefore I think using the existing config option is not OK. An other one has to be added.

3. 
Don't use tabs. Use spaces instead.

4.
Please adhere to the KMail coding style, especially with regard to spaces around parenthesis.

Other than that, the patch seems fine, although I haven't tried it.
Can you please attach an example mail which has these headers?
Comment 3 Sune Vuorela 2007-08-23 01:33:40 UTC
1) Okay. Will do. after looking at the source, s/readBoolEntry/readEntry/ on the patch is all it seems to be required.

2) If any mailer adds random headers from the mail it replies to it is severily broken++.

3) Okay.
4) Do you have a link to the style?  I have in general tried to follow the style in the file, whicgh I think I kind of succeeded.

The following snippet is the headers from such mail:

X-Text-Classification: ham
X-POPFile-Link: http://127.0.0.1:7070/jump_to_message?view=234116

or

X-Text-Classification: server_reports
X-POPFile-Link: http://127.0.0.1:7070/jump_to_message?view=233811

or whatever your buckets are called.

The rest of the mails is just like any other email.

I unfortunately haven't got a kde4 environment running at this time, but the patch works at kde3, and the files I patch doesn't seem to have changed much.

/Sune
Comment 4 Björn Ruberg 2010-01-10 23:07:29 UTC
What's the status of this. Can we get a patch for KDE trunk? (based on 4.4 maybe)
Comment 5 Laurent Montel 2011-08-30 08:05:10 UTC
Status please 
Otherwise I will close it
Comment 6 Sune Vuorela 2011-08-30 08:25:04 UTC
I haven't tested the patch in ages, and I'm not using 'popfile' any longer for spam filtering so I also don't really have the test data.
Comment 7 Myriam Schweingruber 2012-08-18 08:53:36 UTC
Thank you for your feature request. Kmail1 is currently unmaintained so we are closing all wishes. Please feel free to reopen a feature request for Kmail2 if it has not already been implemented.
Thank you for your understanding.
Comment 8 Luigi Toscano 2012-08-19 00:26:11 UTC
Instead of creating a new feature request, please confirm here if the wishlist is still valid for kmail2.