Bug 148912 - geolocalization editor does not work with non-jpeg file types
Summary: geolocalization editor does not work with non-jpeg file types
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-GeolocationEdit (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-16 23:21 UTC by Thorsten Schnebeck
Modified: 2022-01-07 17:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Schnebeck 2007-08-16 23:21:10 UTC
Version:            (using KDE KDE 3.5.7)
Installed from:    Compiled From Sources
OS:                Linux

exiv2 is able to write geodata metadata into e.g png files.
Its easy to tests this: Take a jpeg, add geo-data with the kipi-plugin, open in digikams image editor and save as png. You will see, the geo-data are part of the png metadata.

But you can not add these geo-tag direct into a png, as you can find code like this in this plugin:

[...]
// We only add all JPEG files as R/W because Exiv2 can't yet 
// update metadata on others file formats. 
   QFileInfo fi(url.path()); 
   QString ext = fi.extension(false).upper(); 
   bool ret = false; 
   if (ext == QString("JPG") || ext == QString("JPEG") || ext == QString("JPE")) 
   {
[...] 

So, the comment in the source code is definitely wrong and to test the file format a simple extention is used. What about kde standard test to check a filetype based on MIME data?

KMimeType::Ptr type = KMimeType::findByURL("/home/bernd/foobar.jpg");
vs
KMimeMagicResult *result = KMimeMagic::self()->findFileType("/home/bernd/foobar.jpg");

(from: http://developer.kde.org/documentation/library/kdeqt/kde3arch/mime.html )

Bye

  Thorsten
Comment 1 Thorsten Schnebeck 2007-09-02 22:55:25 UTC
> Your mail to 'Kde-imaging' with the subject
>
>     [Bug 148912] New: geolocalization kipi plugin does not work with
> non-jpeg file types
>
> Is being held until the list moderator can review it for approval.
>
> Buggy bug management system:
>
> The reason it is being held:
>
>     Post by non-member to a members-only list
>
> Either the message will get posted to the list, or you will receive
> notification of the moderator's decision.  If you would like to cancel
> this posting, please visit the following URL:
>
>    
> https://mail.kde.org/mailman/confirm/kde-imaging/ce90e191bbdf0e44088e7d75db
>69761e73c81776

I close this bug report as this mail is __STILL__ not forwarded to the developers, open a new one and assign that to the wrong package.

Thanks list admin :-/

Thorsten