Bug 148865 - kdegraphics and OpenEXR-1.6.0 kfile_exr.o
Summary: kdegraphics and OpenEXR-1.6.0 kfile_exr.o
Status: ASSIGNED
Alias: None
Product: kfile-plugins
Classification: Applications
Component: exr (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Brad Hards
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-15 21:02 UTC by Taurnil
Modified: 2023-01-05 18:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
kdegraphics compile log (44.80 KB, application/x-bzip2)
2007-08-15 21:03 UTC, Taurnil
Details
kdegraphics config.log (239.24 KB, text/x-log)
2007-08-15 21:04 UTC, Taurnil
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Taurnil 2007-08-15 21:02:28 UTC
Version:            (using KDE KDE 3.5.7)
Installed from:    Compiled From Sources
Compiler:          gcc-4.1.2 
OS:                Linux

make kdegraphics fails with openexr-1.6.0 installed. I had found a similar issue here; http://linuxfromscratch.org/pipermail/blfs-support/2007-April/062700.html and had the same results. While dropping openexr is an option this should most likely be fixed.
Comment 1 Taurnil 2007-08-15 21:03:30 UTC
Created attachment 21400 [details]
kdegraphics compile log
Comment 2 Taurnil 2007-08-15 21:04:35 UTC
Created attachment 21401 [details]
kdegraphics config.log
Comment 3 Josef Weidendorfer 2007-08-16 15:06:01 UTC
This has nothing to do with valgrind/callgrind
Comment 4 Brad Hards 2007-08-17 01:23:57 UTC
Will take a look. May be a couple of weeks, due travel.
Comment 5 Taurnil 2007-08-21 15:31:23 UTC
I can assist with patch testing when you need it.
Comment 6 Brad Hards 2007-08-21 21:07:51 UTC
OK, looks like the OpenEXR kimg plugin doesn't have build problems in KDE4.
Comment 7 Brad Hards 2007-08-21 21:14:25 UTC
Looks like OpenEXR metadata isn't working in KDE4, due to continued strigi breakage. 

This bug needs to stay open until after the KDE4 port.
Comment 8 Brad Hards 2007-08-22 09:21:15 UTC
KDE3 EXR kimgio plugin appears to compile OK.
Comment 9 Brad Hards 2007-08-22 09:33:55 UTC
OK, can duplicate.
Comment 10 Taurnil 2007-08-22 11:53:22 UTC
Hmm, strigi. I do have 0.5.1 installed and running kde 3.5.7. Tried removing strigi and recompiled kdegraphics same results. Oh well.
Comment 11 Brad Hards 2007-08-22 14:13:13 UTC
Taurnil,

Sorry, that comment about strigi wasn't intended for you - it was just a reminder for me that this bug needs to be fixed for KDE3 and KDE4.

I normally try to fix my bugs in KDE4 and ten backport, but in this case the KDE4 OpenEXR code is all disabled, pending the strigi people porting it.

So I'll just fix it in KDE3 for now.
Comment 12 Brad Hards 2007-08-22 14:19:21 UTC
SVN commit 703387 by bhards:

One of the "standard" attribute names changed between
OpenEXR 1.4.0 and OpenEXR 1.6.0. At this stage I'm assuming
that the change was intentional, and will remain for future
releases - there is an open query on the EXR mailing list
about this.

This still needs to get fixed for trunk, when the strigi
porting is done, so the bug remains open.

CCBUG: 148865


 M  +8 -0      kfile_exr.cpp  


--- branches/KDE/3.5/kdegraphics/kfile-plugins/exr/kfile_exr.cpp #703386:703387
@@ -32,6 +32,7 @@
 #include <ImfVecAttribute.h>
 #include <ImfPreviewImage.h>
 #include <ImfVersion.h>
+#include <ImfCRgbaFile.h>
 
 #include <iostream>
 
@@ -226,7 +227,14 @@
 			qcapDateString.setLength(capDateString.size());
 			appendItem( stdgroup, "Capture Date", qcapDateString );
 		}
+		// This define was introduced in EXR 1.6.0
+#ifndef IMF_B44_COMPRESSION
+		// This is the 1.4 and earlier version
 		if ( hasutcOffset(h) ) {
+#else
+		// This is the 1.6.0 and later version
+		if ( hasUtcOffset(h) ) {
+#endif
 			QString UTCOffset;
 			if (utcOffset(h)>0.0) {
 				UTCOffset.append(QString("%1").arg(utcOffset(h)/3600, 0, 'f', 1));
Comment 13 Brad Hards 2007-08-22 14:21:37 UTC
For anyone experiencing this bug:
Please update to at least revision 703387 and try to compile again.

Please let me know how it goes.

Note: this bug should remain open for KDE4.
Comment 14 Taurnil 2007-08-22 16:08:06 UTC
No problem Brad about the strigi thing. Figured I'd stab it anyway just to see what happened.

Tried your SVN commit 703387 and the make got past the error.

Thank you.
Comment 15 Justin Zobel 2021-03-09 23:43:26 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 16 Taurnil 2023-01-05 18:06:39 UTC
This can be closed if you like, its not been an issue for me since whenever.