Bug 146601 - Error during renaming of images being sent via email
Summary: Error during renaming of images being sent via email
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-SendByMail (show other bugs)
Version: 5.6.0
Platform: Ubuntu Linux
: HI wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-09 21:43 UTC by Geoff King
Modified: 2017-07-10 10:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff King 2007-06-09 21:43:47 UTC
Version:           SVN (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages
OS:                Linux

This is a followup to Bug #140477, which is marked as resolved. I posted there also. 
Two comments to new renaming ability of the "Emailing Images": 

1)  I think that the user should be able to turn this renaming on or off.
There are times where I might not want to send the comments and would
rather just have original file names. For example, some of my comments are 
rather long and I'd rather have simple filenames or as in cases below.  I think this should
be accomplished with a checkbox in the dialog.

2)  The kmail send fails with an error when comments have certain characters.  For
example, I get an an error box when a "?" is in the comment.

I am new to this mailing list - please let me know if I'm doing this wrong by creating a new bug for this. Thanks for a great program.
Comment 1 Angelo Naselli 2007-06-10 23:16:18 UTC
> This is a followup to Bug #140477, which is marked as resolved. I posted there also. 
> Two comments to new renaming ability of the "Emailing Images": 
> 
> 1)  I think that the user should be able to turn this renaming on or off.
> There are times where I might not want to send the comments and would
> rather just have original file names. For example, some of my comments are 
> rather long and I'd rather have simple filenames or as in cases below.  I think this should
> be accomplished with a checkbox in the dialog.
> 
> 2)  The kmail send fails with an error when comments have certain characters.  For
> example, I get an an error box when a "?" is in the comment.
> 
> I am new to this mailing list - please let me know if I'm doing this wrong by creating a new bug for this. Thanks for a great program.


Hi Geoff,
even if I believe Michael will take care about it,
should be better to add two bug reports in a future.
The reason is they are two different problems, the first is
a wish, if I've understood correctly, and should be marked
as. The latter sounds like a bug to me, but in any case
they should have different kind of implementation and leave them 
together could make hard to follow which bug we're fixing and which
not yet.

TIA,
	Angelo
Comment 2 Geoff King 2007-06-11 13:26:19 UTC
Understood -  Next time if have long or multiple reports like this I
will split them up.

On 10 Jun 2007 21:16:19 -0000, Angelo Naselli <anaselli@linux.it> wrote:
[bugs.kde.org quoted mail]
Comment 3 Michael Höchstetter 2007-06-11 16:52:46 UTC
hi,
1) i agree with a checkbox!
2) what else characters are to be excluded? i already thought about that and i change all disallowed to _. But i forgot the ?. Are there more left?
I think i can do it tomorrow in the evening. 

Angelo, please do not release a new version until it is fixed!
Michael
Comment 4 Geoff King 2007-06-12 00:35:55 UTC
Hi Michael, 

I can't find any more characters that cause the same error message as the ?.

However, I did find one more instance where double quotes " cause problems. I suggest that the " also be disallowed or changed to single quotes ' since those don't seem to cause problems. 

It appears that when there are quotes such as "word" in a comment the new name gets truncated at the first " as a kmail attachment.  The tmp files appear to get created properly in the tmp directory, but kmail truncates them when attaching. There is no error box and they are attached to the email.  When there are multiple files, each is attached with the same name because the new version number is truncated also.  
(Let me know if you want this reported as a separate bug).

Geoff
Comment 5 Michael Höchstetter 2007-06-13 08:18:58 UTC
i added a checkbox, so that the user can decide if he wants the name substitution or not.
Furthermore, i fixed the question and quotation mark problems, by simply eliminating the symbol. 
Comment 6 Geoff King 2007-06-14 01:18:26 UTC
Sweet - It all is working great. Thanks.
Comment 7 caulier.gilles 2017-07-10 10:13:45 UTC
This problem is not reproducible with new Send By Mail tool from digiKam core version 5.7.0.

Gilles Caulier