Bug 146436 - digikam try to include Exiv2 library headers
Summary: digikam try to include Exiv2 library headers
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Unclassified
Component: Bundle-Tarball (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-06 00:37 UTC by Marcin Garski
Modified: 2022-02-04 06:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Garski 2007-06-06 00:37:00 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

On digiKam website I can see such text about 0.9.2 release:
"- Removing direct Exiv2 library depency. libkexiv2 interface is used everywhere instead."

But if we look into the libs/widgets/metadata/makernotewidget.cpp file you will notice:
// LibExiv2 includes.

#include <exiv2/exif.hpp>
#include <exiv2/tags.hpp>
#include <exiv2/ifd.hpp>

So digiKam directly requires Exiv2 and won't compile if this headers will not be installed.
Comment 1 caulier.gilles 2007-06-06 00:45:45 UTC
SVN commit 671981 by cgilles:

fix broken compilation duing obsolete Exiv2 depency
BUG: 146436


 M  +0 -13     makernotewidget.cpp  


--- branches/extragear/kde3/graphics/digikam/libs/widgets/metadata/makernotewidget.cpp #671980:671981
@@ -22,13 +22,6 @@
  * 
  * ============================================================ */
 
-// C++ includes.
-
-#include <cstdlib>
-#include <cstdio>
-#include <cassert>
-#include <string>
-
 // Qt includes.
 
 #include <qmap.h>
@@ -38,12 +31,6 @@
 
 #include <klocale.h>
 
-// LibExiv2 includes.
-
-#include <exiv2/exif.hpp>
-#include <exiv2/tags.hpp>
-#include <exiv2/ifd.hpp>
-
 // Local includes.
 
 #include "ddebug.h"