Bug 146364 - incremental search for tags in all tag fields
Summary: incremental search for tags in all tag fields
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-04 19:47 UTC by Juergen Flosbach
Modified: 2012-08-28 16:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Flosbach 2007-06-04 19:47:36 UTC
Version:           0.9.2-beta2 (using KDE 3.5.5 "release 45.1" , openSUSE )
Compiler:          Target: x86_64-suse-linux
OS:                Linux (x86_64) release 2.6.13-15.15-default

I use tags tree everywhere in digikam.
And, it's very good implemented with the ability for incremental search
in the comments/tag field.
So I'm wondering why we don't have the same ability of incremental
searching the tags in all tags fields
( left side : tags-list, right side : tags-filter plus comments/tags field ).

Please add this incremental search capability to all tags fields.

Thanks

Juergen Flosbach
Comment 1 Arnd Baecker 2007-10-03 07:47:57 UTC
Full agreement! Having such an incremental search in all tags fields 
and in addition for the album list (left sidebar) and maybe even for the
searches would be extremely useful.

I had a look in the code after Gilles pointed me in the right direction.
If I understand things correctly, all these views (like AlbumFolderView,
or TagFolderView) inherit from FolderView::FolderView.
So it should be possible to create a new FolderViewIncrFilter
which has the filtering built in.
For this one "only" has to borrow the code from 
digikam/libs/imageproperties/imagedescedittab.cpp, 
routine ImageDescEditTab::ImageDescEditTab
to set up the incremental search box and connect the signal correctly.
For this one would have to use void ImageDescEditTab::slotTagsSearchChanged()
as basis.
Does not sound that difficult, but at a first glance
it seems creating a new widget is a bit above my present Qt coding abilities ...
(Of course, if the above approach seems reasonable, and someone wants
to hand-hold me a bit in the first steps, I could give it a try ;-)





Comment 2 caulier.gilles 2007-11-25 21:56:48 UTC
SVN commit 741527 by cgilles:

digiKam from KDE3 branch : new text filters have been added to the bottom of left and right sidebars. View listed below can be filtered:
- Album folder view.
- Tags folder view.
- Search folder view
- Tags Filter folder view.

When user type a string, a search is performed to tree view contents and only items including the strings are displayed. 
A screenshot of digiKam in action is available at this url:

http://digikam3rdparty.free.fr/Screenshots/digikam0.9.3-searchfolderbar.png

BUG: 133191
BUG: 146364
CCBUGS: 110136
CCMAIL: digikam-devel@kde.org



 M  +69 -1     albumfolderview.cpp  
 M  +5 -0      albumfolderview.h  
 M  +86 -11    digikamview.cpp  
 M  +34 -1     searchfolderview.cpp  
 M  +9 -0      searchfolderview.h  
 M  +68 -0     tagfilterview.cpp  
 M  +5 -0      tagfilterview.h  
 M  +68 -0     tagfolderview.cpp  
 M  +5 -0      tagfolderview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=741527
Comment 3 caulier.gilles 2007-11-26 09:43:11 UTC
SVN commit 741717 by cgilles:

backport commits #741527 from KDE3 branch: new text filters have been added to the bottom of left and right sidebars. View listed below can be filtered:
- Album folder view.
- Tags folder view.
- Search folder view
- Tags Filter folder view.

When user type a string, a search is performed to tree view contents and only items including the strings are displayed.
A screenshot of digiKam in action is available at this url:

http://digikam3rdparty.free.fr/Screenshots/digikam0.9.3-searchfolderbar.png

CCBUGS: 133191
CCBUGS: 146364
CCBUGS: 110136
CCMAIL: digikam-devel@kde.org


 M  +69 -0     albumfolderview.cpp  
 M  +7 -1      albumfolderview.h  
 M  +85 -12    digikamview.cpp  
 M  +33 -0     searchfolderview.cpp  
 M  +10 -1     searchfolderview.h  
 M  +68 -0     tagfilterview.cpp  
 M  +5 -0      tagfilterview.h  
 M  +68 -0     tagfolderview.cpp  
 M  +5 -0      tagfolderview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=741717