Bug 145735 - Delete should offer the user to move the images to the trash can
Summary: Delete should offer the user to move the images to the trash can
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2007-05-21 08:18 UTC by Jesper Pedersen
Modified: 2009-12-31 09:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
path to offer the user to move the images to the trash (9.29 KB, patch)
2009-10-13 21:35 UTC, Kirill Kalyuzhniy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Pedersen 2007-05-21 08:18:45 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

As the title says, instead of just nuking the images from disk, they should be moved to the trashcan - and as for other KDE apps, it should still be possible to just nuke completely from disk (see e.g. KMail)
Comment 1 rlk 2007-05-21 14:35:19 UTC
Be aware that this may take a very long time and use a lot of disk space if the images are on a different filesystem.  KPA is designed to handle large numbers of very large objects; it isn't quite the same thing as deleting a few small files or files that live in your home directory.
Comment 2 Jesper Pedersen 2007-05-21 14:43:33 UTC
I completely agree. It should either be part of the dialog, or an option I guess.
Comment 3 Baptiste MATHUS 2007-05-21 18:47:40 UTC
Agreed. For those who don't follow the ml, here's the thread where we already talked a lot about the delete dialog: http://mail.kdab.net/mailman/pipermail/kphotoalbum/2007-May/003262.html.

In fact, I think the idea about doing as many buttons as functions it has, like KDE, gnome do when logging out is a good one. So, in this case, adding another button to move to the trashcan could be simple to do. 
Comment 4 Jesper Pedersen 2007-05-22 07:51:24 UTC
It was not my intention to assign it to me, only to move it out of the new state
Comment 5 Jesper Pedersen 2009-07-24 11:24:08 UTC
The code for this is located in DeleteDialog::deleteImages (which is in MainWindow/DeleteDialog.cpp)
Comment 6 Kirill Kalyuzhniy 2009-10-13 21:35:34 UTC
Created attachment 37562 [details]
path to offer the user to move the images to the trash
Comment 7 Jesper Pedersen 2009-10-13 21:55:02 UTC
Awesome, looks great, thanks.

AS you might know KPhotoAlbum is currently in feature freeze until the release in little over a week. I'll apply the patch ones that phase is over.

Rock On!
Jesper.
Comment 8 Miika Turkia 2009-12-31 06:54:53 UTC
Thanks for the patch. It is applied to trunk now.
Comment 9 Jesper Pedersen 2009-12-31 09:32:40 UTC
Kirill. thanks for the patch, and sorry for the delay. As theBro said, its now been applied to trunk.

I'd be glad if you wanted to work on more KPhotoAlbum issues.

Cheers
Jesper.