Bug 145010 - do not scan mount-points
Summary: do not scan mount-points
Status: RESOLVED UPSTREAM
Alias: None
Product: filelight
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Max Howell
URL:
Keywords:
: 230391 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-05-04 10:46 UTC by Maciej Pilichowski
Modified: 2010-05-29 19:11 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2007-05-04 10:46:32 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    SuSE RPMs

Please do not scan mount-points because it make no sense while analyzing stats of the disk/partition. For example, I have two partitions: one mounted as / and the second as /home. 
When scanning / FL scans also /home -- but it is irrelevant, I could wipe out entire /home and there will be no extra space for /.

The same goes for symlinks (I didn't check if FL scan those).
Comment 1 Jakub Stachowski 2010-03-14 18:28:44 UTC
There is option to disable scanning across mount points in current version. Could you test it and close the bug if this is what you wanted?
Comment 2 Maciej Pilichowski 2010-03-15 17:24:06 UTC
In what version this option should be available, I downloaded latest for OS and I still don't see it (1.9RC).
Comment 3 Jakub Stachowski 2010-03-16 16:12:09 UTC
*** Bug 230391 has been marked as a duplicate of this bug. ***
Comment 4 Jakub Stachowski 2010-03-16 16:14:34 UTC
In 1.9rc3:
Settings -> Configure filelight -> "Scanning" tab -> "Scan across filesystem
boundaries" checkbox, right below list of directories to exclude. It should be
unchecked.
Comment 5 Maciej Pilichowski 2010-03-16 17:08:47 UTC
a) subwish -- please change the label to something more direct like "skip the mount points", because now it is a little ambigous

b) I think "checked", because this would mean to limit the search

c) checked/unchecked, both return the same results, i.e. mount point is included
Comment 6 Jakub Stachowski 2010-03-16 19:14:15 UTC
Do both '/' and '/home' appear on summary screen?
Also please provide contents of: /etc/mtab, /etc/fstab and ~/.kde/share/config/filelightrc .
Comment 7 Maciej Pilichowski 2010-03-16 21:27:14 UTC
> Do both '/' and '/home' appear on summary screen?

Actually it is /storage and /home. Yes, they both appear. 

I cannot reveal my mtab (in fstab there is no interesting entry), but in short. I have /storage and /home (mount points!, not just regular directories) and then I have symlink /home/storage pointing to /storage. 

In such scenario FL traverse /storage while traversing /home. Since FL correctly recognizes active mount points the missing part is taking it into account (probably the real location of symlink, i.e. target point).
Comment 8 Jakub Stachowski 2010-03-16 21:59:38 UTC
If you scan '/' does it go into /storage and /home (I assume you don't have any symlinks that would cause that)? I need to know if whole mountpoint detection is broken for you or it is only if symlink points to different filesystem.
Comment 9 Maciej Pilichowski 2010-03-17 17:17:54 UTC
I will answer (?) ASAP, but I have problem with making such test -- today after launching FL I cannot get to situation when I have /storage in the start window (previously it was always present). Of course /storage exists, it is mounted, operational, etc. Simply FL does not detect it anymore (at all; no matter what checkbox I set on/off).
Comment 10 Jakub Stachowski 2010-03-17 17:31:45 UTC
Around 1.9rc<something> summary widget started using Solid to enumerate filesystems. Unfortunately, HAL (used by Solid) lacks support for LVM and MD so it might be the bug (still open) you are hitting. But this is mostly independent from original issue described in this bug: scanning other filesystem even if disabled. So if you disable "Scan across filesystem boundaries" does scanning "/" go into "/storage" and "/home" (assuming there are no symlinks to /home and /storage) ?
Comment 11 Maciej Pilichowski 2010-03-18 16:33:54 UTC
About /storage being visible in opening dialog -- all I did previously was rebooting machine and it vanished as I described. I rebooted it again, and not it appeared back.

Now, I made a mistake describing the structure, sorry for that -- it is /home/.storage not /storage.

CLEAN VERSION:
-------------

There is / and /home (mount point, static, in fstab) within it.

FL works for / as expected (I checked both settings).

There is /home and /home/.storage within it (and /home/storage as symlink to /home/.storage) -- it is dynamically assigned mount point (i.e. it is not present in fstab only in mtab).

FL does not work for /home as expected because for both settings it includes /home/.storage (mount point) in calculating space.

FL ignores symlink /home/storage (correct) in both cases.
Comment 12 Martin Sandsmark 2010-05-26 23:30:58 UTC
I can't fix HAL, sorry (if I had more spare time...).

And "mount points" is domain specific naming, I want to keep that out of the UI. If you have some better ideas for naming stuff, though, please open a separate bug report.
Comment 13 Maciej Pilichowski 2010-05-27 16:32:24 UTC
What HAL has to do with it?

If the option is set to ignoring nested mount points all it takes is reading /etc/mtab, using first column as a filter for currently checked partition and getting the second column as "black list" (and omitting entries from it later, while scanning).

Reopening, because obviously the problem is not HAL.
Comment 14 Martin Sandsmark 2010-05-27 21:26:36 UTC
Filelight gets the paths of all mountpoints from Solid, which in turns gets it from HAL, when running on Linux.

When launching Filelight, it should print out a list of detected mounts. If this doesn't correspond to the actual list of mounted filesystems on your system, please file a bug against HAL (or Solid, though I'm pretty sure they'll just re-file it against HAL, since Solid just is an abstraction layero).

Adding platform-specific code to parse random files is ugly and not very portable, and I'd rather avoid it.
Comment 15 Maciej Pilichowski 2010-05-29 19:11:21 UTC
Posted:
https://bugs.kde.org/show_bug.cgi?id=239999