Bug 143676 - min and max bitrates not enabled in configuration dialog
Summary: min and max bitrates not enabled in configuration dialog
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Unmaintained
Component: audiocd (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: icefox
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-31 19:02 UTC by thomas
Modified: 2018-04-01 19:46 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description thomas 2007-03-31 19:02:47 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    Compiled From Sources
Compiler:          gcc 3.4.4 pre 
OS:                Linux

In the configuration dialog for ogg vorbis, the max and min
bitrate selectors are never enabled.  Here is a patch:

--- kdemultimedia-3.5.6-orig/kioslave/audiocd/plugins/vorbis/encodervorbisconfig.ui 2005-09-10 04:19:49.000000000 -0400
+++ kdemultimedia-3.5.6/kioslave/audiocd/plugins/vorbis/encodervorbisconfig.ui 2007-03-30 17:33:41.000000000 -0500
@@ -405,6 +405,18 @@
         <receiver>vorbis_quality_settings</receiver>
         <slot>setShown(bool)</slot>
     </connection>
+    <connection>
+      <sender>kcfg_set_vorbis_min_br</sender>
+      <signal>toggled(bool)</signal>
+      <receiver>kcfg_vorbis_min_br</receiver>
+      <slot>setEnabled(bool)</slot>
+    </connection>
+    <connection>
+      <sender>kcfg_set_vorbis_max_br</sender>
+      <signal>toggled(bool)</signal>
+      <receiver>kcfg_vorbis_max_br</receiver>
+      <slot>setEnabled(bool)</slot>
+    </connection>
 </connections>
 <tabstops>
     <tabstop>vorbis_enc_quality</tabstop>
Comment 1 Burkhard Lück 2011-05-24 23:18:45 UTC
Applied your patch and indeed only with the patch it is possible to enable the max and min bitrate selectors.
Thanks a lot for your report, I'll try to get the patch in.
Comment 2 dE 2012-04-27 14:30:41 UTC
(In reply to comment #1)
> Applied your patch and indeed only with the patch it is possible to enable
> the max and min bitrate selectors.
> Thanks a lot for your report, I'll try to get the patch in.

In where? Debian packages or KDE commnits?