Bug 143578 - New Pan Tool crash
Summary: New Pan Tool crash
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Canvas (show other bugs)
Version: 0.9.2
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-29 04:09 UTC by Geoff King
Modified: 2017-09-23 15:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff King 2007-03-29 04:09:40 UTC
Version:           0.9.2-svn (using KDE 3.5.6, Kubuntu (edgy) 4:3.5.6-0ubuntu1~edgy1)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17.14-ubuntu1

When using the the new pan tool the program closes (or crashes) unexpectedly. 
1- Click on thumbnail pan tool in bottom right corner.
2- Hold left mouse button down and it pans around the image. 
3- Release left mouse button and digikam closes unexpectedly. 
This always happens. 
I'm not getting any errors on the terminal when it closes.
Comment 1 Gerhard Kulzer 2007-03-29 07:47:37 UTC
I have the same problem.
I ran digikam in the gdb debugger, the only message I get is :
[New Thread -1219376240 (LWP 3453)]
digikam: /home/gerhard/Fotos/2006/April/img_6926ir.png : PNG file identified
Program exited normally.
(gdb) 
Comment 2 caulier.gilles 2007-03-29 09:30:31 UTC
Gerhard, 

Give me a valgrind backtrace instead GDB. Thanks in advance

Gilles
Comment 3 caulier.gilles 2007-03-29 10:43:06 UTC
SVN commit 647721 by cgilles:

digikam from trunk : use KPopupFrame::hide() instead KPopupFrame::close(int). Sound like some version of close() method are uncomplete with any KDE version.

CCBUGS: 143578

 M  +1 -2      canvas.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/canvas.cpp #647720:647721
@@ -1237,8 +1237,7 @@
 
     if (b)
     {
-        int r;
-        d->panIconPopup->close(r);
+        d->panIconPopup->hide();
         delete d->panIconPopup;
         d->panIconPopup = 0;
     }
Comment 4 caulier.gilles 2007-03-29 10:47:51 UTC
Gerhard, Geoff,

On my computer, there is no crash and no dirty memory (tested with valgrind).

I have seen than KPopupFrame widget from KDE API is uncomplete with any KDE version, especially with close(int) method. The hide() method sound like fine to use instead.

Please give me a feedback. If crash still exist, please look at this page to do a valgrind report :

http://www.digikam.org/?q=contrib

Nota : digikam need to be compiled using "./configure --enable-debug=full", else the report will be empty.

Gilles
Comment 5 Gerhard Kulzer 2007-03-29 13:42:45 UTC
That did it Gilles, I have no problem anymore.
Comment 6 caulier.gilles 2007-03-29 14:04:39 UTC
Geoff,

Before to close this file, please let's me hear if all work fine for you to checkout a digiKam from trunk. Thanks in advance

Gilles
Comment 7 Mikolaj Machowski 2007-03-29 21:59:12 UTC
> Before to close this file, please let's me hear if all work fine for you
> to checkout a digiKam from trunk. Thanks in advance


For me it is working perfectly now. Thank you very much.
BTW - it is possible to make Pan Tool works *exactly* like in GIMP?

At the moment in Digikam you have to press button to show window,
release button, move to rectangled area, move rectangled area.

In GIMP it is all done in one press/release cycle.
Comment 8 Geoff King 2007-03-29 23:26:11 UTC
Solved. Thanks, Geoff