Bug 142566 - Can't change the date of a photo
Summary: Can't change the date of a photo
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Metadata-Date (show other bugs)
Version: 0.9.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-05 21:37 UTC by Frédéric COIFFIER
Modified: 2017-08-12 06:41 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric COIFFIER 2007-03-05 21:37:36 UTC
Version:           0.9.1-rc1 (using KDE KDE 3.5.6)
Installed from:    Gentoo Packages
Compiler:          gcc (GCC) 4.1.1 (Gentoo 4.1.1-r3)
 
OS:                Linux

When I change the date of a photo in the Comments/Tags panel and I click on "Apply", the hour isn't taken in account. So, I'm unable to change the date of a photo with this version (0.9.1-rc1).
Comment 1 Frédéric COIFFIER 2007-03-05 21:40:38 UTC
In fact, it seems the old date is cached so I can't see the change :
1. I select a photo
2. I change the date
3. I select another photo and next, the first one
==> The old date is displayed in the Comments/Tag panel
4. I move to another album and I go bak to the previous album
==> The date has changed
Comment 2 Thomas McGuire 2007-03-27 23:45:44 UTC
See also my comment at bug 141601, comment 2.
I think bug 141601 is the same issue.
Comment 3 caulier.gilles 2007-10-02 09:43:33 UTC
Fred,

This problem still reproductible with 0.9.2 ?

If you can, try also digiKAm 0.9.3-svn...

Thanks in advance

Gilles Caulier
Comment 4 Frédéric COIFFIER 2007-10-02 13:45:04 UTC
I can reproduce the problem with 0.9.2.
The problem exists for Date but not for tags : If I check a tag and if I select another photo, the tag is correctly displayed on the previous photo.
I'll try with digiKAm 0.9.3-svn
Comment 5 Arnd Baecker 2007-10-02 14:06:06 UTC
I can confirm the problem as described in #1 above
with current svn.

Sounds a bit a like a signal is not emitted?
Comment 6 caulier.gilles 2007-10-02 14:12:05 UTC
Yes, Arnd, or a chache problem. Marcel ?

Gilles
Comment 7 Arnd Baecker 2007-10-03 07:59:05 UTC
I had a quick look: in magedescedittab.cpp, the d->dateTimeEdit
is connected with 

void ImageDescEditTab::slotDateTimeChanged(const QDateTime& dateTime)
{
    d->hub.setDateTime(dateTime);
    setMetadataWidgetStatus(d->hub.dateTimeStatus(), d->dateTimeEdit);
    slotModified();
}

So to my naive eye this looks ok. 
However I am wondering, whether an additional explicit call to 
  void ImageDescEditTab::updateDate()
would be necessary?

Comment 8 caulier.gilles 2007-12-04 10:48:12 UTC
*** Bug 145723 has been marked as a duplicate of this bug. ***
Comment 9 caulier.gilles 2008-12-04 20:41:33 UTC
What's news for this report. It still valid using digiKam 0.9.4 ?

Gilles Caulier
Comment 10 Mikolaj Machowski 2008-12-05 21:45:59 UTC
This is still valid with current 0.9.5svn:

1. Change date in Comments panel, click Apply
2. Go to another image and return
3. Date still the same
4. Date only updated after changing to another album and returning

When not clicking Apply I am asked for confirmation date is updated.
Comment 11 Thomas McGuire 2008-12-06 14:28:57 UTC
I think this is fixed with 0.10.0 beta 7.
Comment 12 caulier.gilles 2008-12-15 11:48:56 UTC
Marcel,

I confirm this bug for 0.9.5. I cannot see why it doesn't work. ImageDescEditTab::slotApplyAllChanges() call properly MetadataHub::write() which change date of imageinfo relevant using ImageInfo::setDateTime(). This one dispatch changes using ImageAttributesWatch::imageDateChanged() and AlbumIconView::slotImageAttributesChanged() recieve notification about date changes. In this case, AlbumIconView::updateContents() is called, but date do not change in icon view...

Note : why we have this code here :

void ImageInfo::setCaption(const QString& caption)
{
    AlbumDB* db  = m_man->albumDB();
    return db->setItemCaption(m_ID, caption);
    ImageAttributesWatch::instance()->imageCaptionChanged(m_ID);
}

The return instance sound weird...

For 0.10.0, i confirm: this bug is fixed. Creation date is fixed imediatly in icon view.

Gilles
Comment 13 Marcel Wiesweg 2008-12-16 19:18:37 UTC
Yes it really seems the "return" should be removed there. Maybe it works afterwards?
Comment 14 Russell Adams 2008-12-19 06:44:33 UTC
I am seeing a related bug where when viewing by date in the calendar, changes to date do not take effect. Pressing apply doesn't help. I have to change views, ie: by tag, and then I can change the date and it takes effect.

Digikam 0.9.4
Debian Lenny
Comment 15 caulier.gilles 2008-12-19 07:48:04 UTC
To Marcel #13 : fixed with rev; #898821

Gilles
Comment 16 caulier.gilles 2009-01-09 12:13:53 UTC
Marcel,

What do you think about this file ?

As it's fixed with 0.10.0, do you want to close it as fixed with KDE4 or do you want to fix KDE3 version too ?

Gilles Caulier
Comment 17 Marcel Wiesweg 2009-01-09 13:31:09 UTC
Not sure, currently I prefer to fix bugs for 0.10, and this bug is for KDE3 only. May be a lot of work to debug.
Comment 18 caulier.gilles 2009-01-09 13:36:39 UTC
Marcel,

Note : as Thomas said in comment #11, it's sound fixed for KDE4...

Gilles
Comment 19 Andi Clemens 2009-05-24 15:49:02 UTC
I guess we should close it now? :D

Andi
Comment 20 caulier.gilles 2009-05-24 15:54:41 UTC
If Marcel is agree, fine for me. We will not play with KDE3 code now (:=)))...

Gilles
Comment 21 Andi Clemens 2009-05-24 15:59:01 UTC
I've done so today, and it was not nice :D
I have missed cmake after the first two seconds... SO MUCH nicer!
Comment 22 caulier.gilles 2009-07-11 11:30:21 UTC
This file is fixed in KDE4 code. I close it.

Gilles