Bug 140963 - magnutune store start page is not i18nable
Summary: magnutune store start page is not i18nable
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Unclassified
Component: Internet Services (show other bugs)
Version: unspecified
Platform: openSUSE RPMs Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-31 17:19 UTC by Sven Krohlas
Modified: 2007-01-31 20:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Krohlas 2007-01-31 17:19:10 UTC
Version:           SVN (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs
Compiler:          - -
OS:                Linux

My fist only 98% trivial patch. ;-)
In magnatunebrowser.cpp we show a HTML file which can't be translated. This patch fixes that. I suppose amarok/data/magnatune_start_page.html could be deleted after applying this patch?
Is the coding style ok?


Index: magnatunebrowser.cpp
===================================================================
--- magnatunebrowser.cpp        (Revision 628783)
+++ magnatunebrowser.cpp        (Arbeitskopie)
@@ -500,7 +500,17 @@
     if (!m_polished) {
         m_polished = true;
         updateList( );
-        m_artistInfobox->openURL( KURL( locate( "data", "amarok/data/magnatune_start_page.html" ) ) );
+        m_artistInfobox->begin( KURL( locate( "data", "amarok/data/" ) ) );
+        m_artistInfobox->write( "<table align='center' border='0'><tbody align='center' valign='top'>"
+          "<tr align='center'><td><div align='center'>"
+          "<IMG src='magnatune_logo.png' width='200' height='36' align='center' border='0'>"
+          "</div></td></tr><tr><td><BR>"
+        + i18n( "Welcome to Amarok's integrated Magnatune.com store. If this is the "
+                "first time you run it, you must update the database by pressing the "
+                "'Update' button below." )
+        + "</td></tr></tbody></table>" );
+        m_artistInfobox->end();
+
     }

 }
Comment 1 Ian Monroe 2007-01-31 17:42:39 UTC
As unfortunate as it is, I don't think we have a choice. Please commit!
Comment 2 Sven Krohlas 2007-01-31 20:52:06 UTC
SVN commit 628879 by krohlas:

Dear translators, we are really sorry: we forgot to put i18n() around
those five strings. Anyway, now there is at least a chance that some
of you might be able to translate them.

BUG: 140957
BUG: 140963
CCMAIL: kde-i18n-doc@kde.org



 M  +11 -1     magnatunebrowser.cpp  
 M  +5 -4      magnatuneredownloadhandler.cpp  


--- trunk/extragear/multimedia/amarok/src/magnatunebrowser/magnatunebrowser.cpp #628878:628879
@@ -500,7 +500,17 @@
     if (!m_polished) {
         m_polished = true;
         updateList( );
-        m_artistInfobox->openURL( KURL( locate( "data", "amarok/data/magnatune_start_page.html" ) ) );
+        m_artistInfobox->begin( KURL( locate( "data", "amarok/data/" ) ) );
+        m_artistInfobox->write( "<table align='center' border='0'><tbody align='center' valign='top'>"
+          "<tr align='center'><td><div align='center'>"
+          "<IMG src='magnatune_logo.png' width='200' height='36' align='center' border='0'>"
+          "</div></td></tr><tr><td><BR>"
+        + i18n( "Welcome to Amarok's integrated Magnatune.com store. If this is the "
+                "first time you run it, you must update the database by pressing the "
+                "'Update' button below." )
+        + "</td></tr></tbody></table>" );
+        m_artistInfobox->end();
+
     }
 
 }
--- trunk/extragear/multimedia/amarok/src/magnatunebrowser/magnatuneredownloadhandler.cpp #628878:628879
@@ -26,6 +26,7 @@
 
 #include "qdir.h"
 #include "qmessagebox.h"
+#include <klocale.h>
 
 
 
@@ -50,8 +51,8 @@
     if (previousDownloads.isEmpty()) {
 
         //No previously purchased trak information found. No more to do here...
-        QMessageBox::information( m_parent, "No purchases found!",
-                                  "No previous purchases has been found. Nothing to redownload...\n" );
+        QMessageBox::information( m_parent, i18n( "No purchases found!" ) ,
+                                  i18n( "No previous purchases has been found. Nothing to redownload..." ) + "\n" );
         return;
     }
 
@@ -122,8 +123,8 @@
     else
     {
 
-        QMessageBox::information( m_parent, "Could not re-download album",
-                                  "There seems to be a problem with the selected redownload info file.\n" );
+        QMessageBox::information( m_parent, i18n( "Could not re-download album" ),
+                                  i18n( "There seems to be a problem with the selected redownload info file." ) + "\n" );
 
     }